Merge pull request #51 from AayushSabharwal/as/lazy-str

refactor: avoid building strings in `throw=false` path of `splitdef`

Author: oxinabox

src/ExprTools.jl

@@ -2,9 +2,10 @@ module ExprTools
 
 export args_tuple_expr, combinedef, parameters, signature, splitdef
 
+include("compat.jl")
 include("function.jl")
 include("method.jl")
 include("type_utils.jl")
 include("def_tools.jl")
 
-end  # module
+end  # module

src/compat.jl

@@ -0,0 +1,6 @@
+@static if !isdefined(Base, :LazyString)
+    # `LazyString` was added in Julia 1.8. On older versions fall back to eagerly
+    # building the string; correctness is preserved, only the laziness is lost.
+    LazyString(parts...) = string(parts...)
+end
+

src/function.jl

@@ -26,15 +26,18 @@ function splitdef(ex::Expr; throw::Bool=true)
 
     function invalid_def(section)
         if throw
-            msg = "Function definition contains $section\n$(sprint(Meta.dump, full_ex))"
+            msg = LazyString(
+                "Function definition contains ", section, "\n",
+                sprint(Meta.dump, full_ex),
+            )
             Base.throw(ArgumentError(msg))
         else
             nothing
         end
     end
 
     if !(ex.head === :function || ex.head === :(=) || ex.head === :(->))
-        return invalid_def("invalid function head `$(repr(ex.head))`")
+        return invalid_def(LazyString("invalid function head `", ex.head, "`"))
     end
 
     def[:head] = ex.head
@@ -48,7 +51,9 @@ function splitdef(ex::Expr; throw::Bool=true)
         ex = ex.args[1]  # Focus on the function signature
     else
         quan = length(ex.args) > 2 ? "too many" : "too few"
-        return invalid_def("$quan of expression arguments for `$(repr(def[:head]))`")
+        return invalid_def(
+            LazyString(quan, " of expression arguments for `", def[:head], "`"),
+        )
     end
 
     # Where parameters