refactor: avoid building strings in throw=false path of splitdef#51
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #51 +/- ##
==========================================
+ Coverage 97.40% 97.41% +0.01%
==========================================
Files 5 5
Lines 231 232 +1
==========================================
+ Hits 225 226 +1
Misses 6 6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
AayushSabharwal
force-pushed
the
as/lazy-str
branch
from
July 20, 2026 11:09
35a4a56 to
01421fd
Compare
oxinabox
reviewed
Jul 22, 2026
Comment on lines
+1
to
+5
| @static if !isdefined(Base, :LazyString) | ||
| # `LazyString` was added in Julia 1.8. On older versions fall back to eagerly | ||
| # building the string; correctness is preserved, only the laziness is lost. | ||
| LazyString(parts...) = string(parts...) | ||
| end |
Member
There was a problem hiding this comment.
can we move this into a seperate file called compat.jl that is included at top level?
I find that is helpful find finding things like this that can be deleted once we drop support for older versions
Member
|
other than location this seems fine |
Contributor
Author
|
Thanks for taking a look! |
oxinabox
approved these changes
Jul 22, 2026
Member
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
throw=false, these strings are unused.