Skip to content

Commit f2bcc4f

Browse files
committed
Don't perform useless unlocks.
1 parent 313e27e commit f2bcc4f

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

src/ParallelTestRunner.jl

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1285,7 +1285,8 @@ function runtests(mod::Module, args::ParsedArgs;
12851285
end
12861286

12871287
# print the output generated by each testset
1288-
for (testname, result, output, _start, _stop) in @lock(results, results[])
1288+
# (`@sync` above joined all writers, so `results` is quiescent from here on)
1289+
for (testname, result, output, _start, _stop) in results.value
12891290
if !isempty(output)
12901291
print(io_ctx.stdout, "\nOutput generated during execution of '")
12911292
if result isa Exception || anynonpass(result[])
@@ -1343,7 +1344,7 @@ function runtests(mod::Module, args::ParsedArgs;
13431344
function collect_results()
13441345
with_testset(o_ts) do
13451346
completed_tests = Set{String}()
1346-
for (testname, result, _output, start, stop) in @lock(results, results[])
1347+
for (testname, result, _output, start, stop) in results.value
13471348
push!(completed_tests, testname)
13481349

13491350
if result isa AbstractTestRecord

0 commit comments

Comments
 (0)