Also report time for failed tests

[christiangnrd]

I often find myself wondering how long it took for a test to fail without wanting to set --verbose and do the math myself

If approved, I can also align the start message (and leave the duration section empty) or I can leave it alone since it only shows up when the --verbose flag is set.

[christiangnrd]

🥲

Hopefully print_test_errored isn't part of the public API

[giordano]

No:

ParallelTestRunner.jl/src/ParallelTestRunner.jl

Line 3 in f38c67a

export runtests, addworkers, addworker

[maleadt]

Those methods will become public at the point somebody takes the time to test the interface out (presumably only CUDA.jl will need them).

[christiangnrd]

#37

Terrible timing I'm very aware but should we maybe adjust the print_test_ function signatures before making them public?

Currently print_test_finished seems to swap the test name and the record for some reason.

function print_test_started(::Type{TestRecord}, wrkr, test, ctx::TestIOContext)

function print_test_finished(test, wrkr, record::TestRecord, ctx::TestIOContext)

function print_test_errorred(::Type{TestRecord}, wrkr, test, ctx::TestIOContext, test_time)

I suggest changing print_test_finished to:

function print_test_finished(record::TestRecord, wrkr, test, ctx::TestIOContext)

for consistency with the other 2.

And then CUDA.jl can set its ParallelTestRunner compat to 1.1 or whatever the version we make them public is.