Skip to content

Don't pun on getindex.#56

Closed
maleadt wants to merge 1 commit into
mainfrom
tb/rm_pun
Closed

Don't pun on getindex.#56
maleadt wants to merge 1 commit into
mainfrom
tb/rm_pun

Conversation

@maleadt

@maleadt maleadt commented Oct 17, 2025

Copy link
Copy Markdown
Collaborator

record[] :: TestSet isn't the most logical step to me, while record.testset is much clearer (and easier to grep for).

@maleadt maleadt requested a review from vchuravy October 17, 2025 15:13
@vchuravy

Copy link
Copy Markdown
Member

My motivation here was that anywhere we are potentially handling a AbstractTestRecord we should use an accessory function, instead of assuming the structure.

But using testset(::TestRecord) conflicted with some variable names.

@maleadt

maleadt commented Oct 17, 2025

Copy link
Copy Markdown
Collaborator Author

Mhm. I guess, although I'm getting lest convinced by the need for customizability by replacing the test record structure,

@maleadt maleadt closed this Oct 17, 2025
@vchuravy

Copy link
Copy Markdown
Member

Mhm. I guess, although I'm getting lest convinced by the need for customizability by replacing the test record structure,

Yeah, it might have been a case of generalizing too soon. I was looking at the CUDA.jl files at the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants