Skip to content

Don't pun on getindex. #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
maleadt wants to merge 1 commit into from
Closed

Don't pun on getindex. #56

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions src/ParallelTestRunner.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ end
abstract type AbstractTestRecord end

struct TestRecord <: AbstractTestRecord
value::DefaultTestSet
testset::DefaultTestSet
output::String # captured stdout/stderr

# stats
Expand All @@ -92,10 +92,6 @@ function memory_usage(rec::TestRecord)
return rec.rss
end

function Base.getindex(rec::TestRecord)
return rec.value
end


#
# overridable I/O context for pretty-printing
Expand Down Expand Up @@ -764,7 +760,7 @@ function runtests(mod::Module, ARGS; test_filter = Returns(true), RecordType = T
test_name, wrkr, record = msg[2], msg[3], msg[4]

clear_status()
if anynonpass(record[])
if anynonpass(record.testset)
print_test_failed(record, wrkr, test_name, io_ctx)
else
print_test_finished(record, wrkr, test_name, io_ctx)
Expand Down Expand Up @@ -979,7 +975,7 @@ function runtests(mod::Module, ARGS; test_filter = Returns(true), RecordType = T
push!(completed_tests, testname)

if result isa AbstractTestRecord
testset = result[]::DefaultTestSet
testset = result.testset
historical_durations[testname] = stop - start
else
# If this test raised an exception that means the test runner itself had some problem,
Expand Down