Make it possible to customize the worker a test is run on.#9
Merged
Conversation
In the case of Metal.jl, some tests require specific env vars to be set.
giordano
reviewed
Oct 10, 2025
|
|
||
| Add `X` worker processes, with additional keyword arguments passed to `addprocs`. | ||
| """ | ||
| test_exeflags = Base.julia_cmd() |
Collaborator
There was a problem hiding this comment.
This is set at precompile time, which feels very wrong.
Comment on lines
+225
to
+227
| push!(test_exeflags.exec, "--check-bounds=yes") | ||
| push!(test_exeflags.exec, "--startup-file=no") | ||
| push!(test_exeflags.exec, "--depwarn=yes") |
Collaborator
There was a problem hiding this comment.
I think users may want to control at least --check-bounds or --depwarn?
| push!(test_exeflags.exec, "--startup-file=no") | ||
| push!(test_exeflags.exec, "--depwarn=yes") | ||
| push!(test_exeflags.exec, "--project=$(Base.active_project())") | ||
| test_exename = popfirst!(test_exeflags.exec) |
Collaborator
There was a problem hiding this comment.
Related to the point above that this is set at precompile time, this is going to point to the wrong environment when the package is used in multiple environments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the case of Metal.jl, some tests require specific env vars to be set: