Resolve bundled artifacts without a world-age trampoline - #62
Draft
quinnj wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolve the
tzjdataartifact at runtime without embedding a depot-specific precompile path or relying on the world-age trampoline emitted by the artifact string macro. This keeps artifact lookup relocatable for bundled system images and trim-compiled executables.Implementation
Artifacts.tomlduring precompilation.artifact_dir()is called.Validation
Open Question
The lookup follows the normal artifact-directory search order, but it does not yet apply custom
Overrides.tomlmappings. This remains a draft while the expected override semantics are reviewed.Co-authored by Codex