first prototype for electron based testsuite#14
Open
SimonDanisch wants to merge 6 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14 +/- ##
===========================================
- Coverage 81.38% 55.51% -25.88%
===========================================
Files 7 9 +2
Lines 505 744 +239
===========================================
+ Hits 411 413 +2
- Misses 94 331 +237
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Click the first visible match repeatedly until a JS predicate holds. For clicks whose handler is wired asynchronously (a framework attaches onclick after the element mounts), a lone synthetic click() can race ahead of the handler and be dropped, so click + wait_for hangs forever. click_until re-clicks until the awaited state appears.
Closing the IPC pipe is the graceful exit request, but a wedged headless Electron (CI/xvfb, no dbus) can ignore it and keep running — orphaning its process and libuv handle so the Julia process itself can't exit (manifested as a test that passes then hangs until the job timeout). Kill it if still alive.
`Window` merges kwargs as TOP-LEVEL BrowserWindow options, so calling it as
`Window(app, url; options = Dict("show"=>false, …))` nested the dict under an
"options" key — `show` never reached `new BrowserWindow(opts)` and Electron's
default `show:true` won. Every "headless" (`show=false`) test window was
therefore actually visible and stole focus on the user's desktop. Pass
show/width/height/webPreferences as kwargs instead. Verified live via
`BrowserWindow.isVisible()`: nested → true (shows), kwargs → false (hidden).
A plain hidden (show=false) window has no on-screen surface, so Chromium composites lazily (~1.5fps measured) — which starves requestAnimationFrame even though timers and the main thread run full speed. That makes the BonitoAgents scroll/animation e2e tests (momentum, follow-restore) run rAF ~40x slower than a real browser. offscreen=true switches to OSR, which drives its own BeginFrame source at 60fps regardless of visibility. Opt-in (default false) so screenshot-based suites keep the existing render path.
This Testing module exists to drive headless UI tests, where faithful rAF timing matters: a plain hidden window starves requestAnimationFrame (~1.5fps), OSR drives 60fps. So OSR is the correct default — consumers (e.g. BonitoAgents' e2e harness) inherit it automatically; pass offscreen=false to opt out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still need to decide on where to put it.
Would also be nice to have this with the bonito
js"..."string macro.Still has some code in it I would like to clean up.
Lets you record videos like this:
https://github.com/user-attachments/assets/4818f987-a038-4d02-ad41-41db7453a086
Code: https://github.com/SimonDanisch/BonitoWidgets.jl/blob/main/examples/walkthrough.jl