Skip to content

Support IOBuffer writes for HTTP streams#1300

Merged
quinnj merged 2 commits into
masterfrom
codex/stream-unsafe-write
Jun 11, 2026
Merged

Support IOBuffer writes for HTTP streams#1300
quinnj merged 2 commits into
masterfrom
codex/stream-unsafe-write

Conversation

@quinnj

@quinnj quinnj commented Jun 11, 2026

Copy link
Copy Markdown
Member

Summary

  • add Base.unsafe_write for HTTP.Stream by copying pointer data and delegating through the existing stream byte write path
  • cover IOBuffer writes for server stream responses and HTTP.open request bodies

Tests

  • julia --project=. -e 'include("test/http_server_http1_tests.jl")'\n- julia --project=. -e 'include("test/http_client_tests.jl")'\n\nCo-authored by Codex

@codecov

codecov Bot commented Jun 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.86%. Comparing base (6022a9f) to head (de5d050).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1300      +/-   ##
==========================================
+ Coverage   86.83%   86.86%   +0.03%     
==========================================
  Files          28       28              
  Lines       10799    10803       +4     
==========================================
+ Hits         9377     9384       +7     
+ Misses       1422     1419       -3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Exercise the zero-length unsafe_write path added for stream IOBuffer support so Codecov sees the no-op branch covered.
@quinnj quinnj merged commit ddc852c into master Jun 11, 2026
8 checks passed
@quinnj quinnj deleted the codex/stream-unsafe-write branch June 11, 2026 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant