permessage-deflate support#868
Closed
Mixfair wants to merge 3 commits into
Closed
Conversation
503e4f8 to
2c9a6cb
Compare
fredrikekre
reviewed
Jun 27, 2022
3267f59 to
fb7111e
Compare
Codecov Report
@@ Coverage Diff @@
## master #868 +/- ##
==========================================
- Coverage 80.12% 76.23% -3.89%
==========================================
Files 36 36
Lines 2878 2925 +47
==========================================
- Hits 2306 2230 -76
- Misses 572 695 +123
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
fb7111e to
c3a3b7c
Compare
Member
|
Implemented in #1308; sorry for the slow response/review here. As the websocket code has been completely re-done for the 2.0 release, I ended up doing the support along with the rewrite. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi.
Sharing my example of implementing permessage-deflate using CodecZlib in continuation #853.
In the process, I encountered fragmentation difficulties, since the
opcodeis calculated during the process of sending data and we do not know about the type of compressed data. Therefore, I decided to separately compress a string into a string, an array into an array before sending. Also moved utf-8 check after unpacking. Tested with Chrome and Julia client.Please, review it
Server:
Client: