Skip to content

fix: throw error instead of assertion for CA config read failure#55

Merged
aviks merged 3 commits into
JuliaWeb:mainfrom
pfitzseb:patch-1
Nov 29, 2025
Merged

fix: throw error instead of assertion for CA config read failure#55
aviks merged 3 commits into
JuliaWeb:mainfrom
pfitzseb:patch-1

Conversation

@pfitzseb

Copy link
Copy Markdown
Contributor

Makes the error reporting for that code path a bit more obvious. In light of #54, we could also mention the env vars here?

@codecov

codecov Bot commented Nov 18, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 74.68%. Comparing base (10f7b7b) to head (3e02148).
⚠️ Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
src/ssl.jl 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #55      +/-   ##
==========================================
- Coverage   77.56%   74.68%   -2.88%     
==========================================
  Files           2        2              
  Lines        1083     1114      +31     
==========================================
- Hits          840      832       -8     
- Misses        243      282      +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread src/ssl.jl Outdated
@aviks

aviks commented Nov 25, 2025

Copy link
Copy Markdown
Member

We should incorporate this for help debugging future errors, but a proper fix for #54 also needs to be made.

Comment thread src/ssl.jl Outdated
@aviks aviks merged commit 47166f8 into JuliaWeb:main Nov 29, 2025
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants