fix: throw error instead of assertion for CA config read failure#55
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #55 +/- ##
==========================================
- Coverage 77.56% 74.68% -2.88%
==========================================
Files 2 2
Lines 1083 1114 +31
==========================================
- Hits 840 832 -8
- Misses 243 282 +39 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aviks
reviewed
Nov 25, 2025
Member
|
We should incorporate this for help debugging future errors, but a proper fix for #54 also needs to be made. |
aviks
reviewed
Nov 29, 2025
aviks
approved these changes
Nov 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the error reporting for that code path a bit more obvious. In light of #54, we could also mention the env vars here?