Skip to content

Commit a356dc4

Browse files
committed
test: fix failing tests
1 parent 8daf69a commit a356dc4

File tree

1 file changed

+10
-8
lines changed

1 file changed

+10
-8
lines changed

packages/bentocache/tests/tracing_channels.spec.ts

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -167,15 +167,15 @@ test.group('Tracing Channels', () => {
167167

168168
await cache.getOrSet({ key: 'foo', factory: () => 'new' })
169169

170-
// Should only have a get trace (hit), no set
171-
const getMessages = collector.messages.end.filter((m) => m.operation === 'get')
170+
// Should only have a getOrSet trace (hit), no set
171+
const getOrSetMessages = collector.messages.end.filter((m) => m.operation === 'getOrSet')
172172
const setMessages = collector.messages.end.filter((m) => m.operation === 'set')
173173

174-
assert.lengthOf(getMessages, 1)
174+
assert.lengthOf(getOrSetMessages, 1)
175175
assert.lengthOf(setMessages, 0)
176176

177-
assert.equal(getMessages[0].hit, true)
178-
assert.equal(getMessages[0].tier, 'l1')
177+
assert.equal(getOrSetMessages[0].hit, true)
178+
assert.equal(getOrSetMessages[0].tier, 'l1')
179179
})
180180

181181
test('traces getOrSet with cache miss (get + set)', async ({ assert, cleanup }) => {
@@ -186,13 +186,15 @@ test.group('Tracing Channels', () => {
186186

187187
await cache.getOrSet({ key: 'newkey', factory: () => 'newvalue' })
188188

189-
const getMessages = collector.messages.end.filter((m) => m.operation === 'get')
189+
const getOrSetMessages = collector.messages.end.filter((m) => m.operation === 'getOrSet')
190+
const factoryMessages = collector.messages.end.filter((m) => m.operation === 'factory')
190191
const setMessages = collector.messages.end.filter((m) => m.operation === 'set')
191192

192-
assert.lengthOf(getMessages, 1)
193+
assert.lengthOf(getOrSetMessages, 1)
194+
assert.lengthOf(factoryMessages, 1)
193195
assert.lengthOf(setMessages, 1)
194196

195-
assert.equal(getMessages[0].hit, false)
197+
assert.equal(getOrSetMessages[0].hit, false)
196198
assert.equal(setMessages[0].key, 'bentocache:newkey')
197199
})
198200

0 commit comments

Comments
 (0)