add tests for striping trainling dots

Author: aviatesk

test/datatip.jl

@@ -19,7 +19,7 @@
             @test localdatatip("l", 4) == 3 # line
         end
 
-        # remove dot accessors
+        # ignore dot accessors
         let str = """
             function withdots(expr::CSTParser.EXPR)
                 bind = CSTParser.bindingof(expr.args[1])
@@ -68,8 +68,8 @@
         end
     end
 
-    @testset "toplevel datatips" begin
-        using Atom: topleveldatatip
+    @testset "global datatips" begin
+        using Atom: globaldatatip
 
         ## method datatip
         @eval Main begin
@@ -81,7 +81,7 @@
             datatipmethodtest() = nothing
         end
 
-        let datatip = topleveldatatip("Main", "datatipmethodtest")
+        let datatip = globaldatatip("Main", "datatipmethodtest", "datatipmethodtest")
             @test datatip isa Vector
             firsttip = datatip[1]
             secondtip = datatip[2]
@@ -94,11 +94,16 @@
         ## variable datatip
         @eval Main datatipvariabletest = "this string should be shown in datatip"
 
-        let datatip = topleveldatatip("Main", "datatipvariabletest")
+        let datatip = globaldatatip("Main", "datatipvariabletest", "datatipvariabletest")
             @test datatip isa Vector
             firsttip = datatip[1]
             @test firsttip[:type] == :snippet
             @test occursin(r"this string should be shown in datatip", firsttip[:value])
         end
+
+        ## strips training dots
+        let item = globaldatatip("Atom", "SYMBOLSCACHE", "SYMBOLSCACHE")
+            @test item == globaldatatip("Atom", "SYMBOLSCACHE", "SYMBOLSCACHE.keys")
+        end
     end
 end

test/goto.jl

@@ -31,7 +31,7 @@
             @test localgotoitem("l", 8)[:line] === 7
         end
 
-        # remove dot accessors
+        # ignore dot accessors
         let str = """
             function withdots(expr::CSTParser.EXPR)
                 bind = CSTParser.bindingof(expr.args[1])
@@ -245,13 +245,25 @@
         end
     end
 
-    @testset "goto global symbols" begin # toplevel symbol goto & method goto
+    # bundles `modulegotoitems`, `toplevelgotoitems` and `methodgotoitems`
+    @testset "goto global symbols" begin
         # both the original methods and the toplevel bindings that are overloaded
         # in a context module should be shown
-        let items = globalgotoitems("isconst", "Main.Junk", "", nothing)
+        let items = globalgotoitems("isconst", "isconst", "Main.Junk", "", nothing)
             @test length(items) === 2
             @test "isconst(m::Module, s::Symbol)" ∈ map(item -> item.text, items) # from Base
             @test "Base.isconst(::JunkType)" ∈ map(item -> item.text, items) # from Junk
         end
+
+        # strips trailing dots
+        let item = globalgotoitems("isconst", "isconst", "Main.Junk", "", nothing)
+            @test item == globalgotoitems("isconst", "Junk.isconst", "Main.Junk", "", nothing)
+            @test item == globalgotoitems("isconst", "Main.Junk.isconst", "Main.Junk", "", nothing)
+        end
+        let item = globalgotoitems("Junk", "Junk", "Main.Junk", "", nothing)
+            @test item == globalgotoitems("Junk", "Main.Junk", "Main.Junk", "", nothing)
+            @test item == globalgotoitems("Junk", "Junk.isconst", "Main.Junk", "", nothing)
+            @test item == globalgotoitems("Junk", "Main.Junk.isconst", "Main.Junk", "", nothing)
+        end
     end
 end

test/utils.jl

@@ -94,3 +94,18 @@ end
     @test strlimit("Jμλια in the Nutshell", 21, " ...") == "Jμλια in the Nutshell"
     @test strlimit("Jμλια in the Nutshell", 20, " ...") == "Jμλια in the Nut ..."
 end
+
+@testset "strip trailing dots" begin
+    using Atom: striptrailingdots
+
+    # only including ASCII
+    @test striptrailingdots("field", "Head.field") == "Head.field"
+    @test striptrailingdots("Head", "Head.field") == "Head"
+
+    # including Unicode
+    @test striptrailingdots("fιηλδ", "Hηαδ.fιηλδ") == "Hηαδ.fιηλδ"
+    @test striptrailingdots("Hηαδ", "Hηαδ.fιηλδ") == "Hηαδ"
+
+    # invalid case
+    @test_nowarn striptrailingdots("foo", "head.field")
+end