add method list to datatip (collapsed by default)

Author: aviatesk

src/datatip.jl

@@ -1,7 +1,6 @@
 #=
-@TODO:
-Use our own UI components for this: atom-ide-ui is already deprecated, ugly, not fully functional, and and...
-Once we can come to handle links within datatips, we may want to append method tables as well
+@TODO use our own UI components for this:
+atom-ide-ui is already deprecated, ugly, not fully functional, and and...
 =#
 
 handle("datatip") do data
@@ -74,6 +73,9 @@ function globaldatatip(mod, word, fullword)
 
   processdoc!(docs, docstr, datatip)
 
+  ml = methods(val)
+  processmethods!(ml, datatip)
+
   return datatip
 end
 
@@ -125,6 +127,23 @@ processval!(val::Function, docstr, datatip) = begin
 end
 processval!(::Undefined, docstr, datatip) = nothing
 
+function processmethods!(ml, datatip)
+  ms = collect(ml)
+  isempty(ms) && return
+
+  replace(str, mregex => s"\g<sig> aviin \g<mod> aviat \g<loc>")
+
+  substr = s"<code>\g<sig></code> in <code>\g<mod></code> at \g<loc>"
+  msstr = map(ms) do m
+    s = replace(string(m), methodloc_regex => substr)
+    match(methodloc_regex, string(m))
+    "<li>$s</li>"
+  end |> join
+
+  name = ms[1].name
+  pushmarkdown!(datatip, "<details><summary><code>$name</code> has **$(length(ms))** methods:</summary><ul>$(msstr)</ul></details>")
+end
+
 function pushmarkdown!(datatip, markdown)
   (markdown == "" || markdown == "\n") && return
   push!(datatip, Dict(:type => :markdown, :value => markdown))

src/display/methods.jl

@@ -4,9 +4,11 @@ stripparams(t) = replace(t, r"\{([A-Za-z, ]*?)\}" => "")
 
 interpose(xs, y) = map(i -> iseven(i) ? xs[i÷2] : y, 2:2length(xs))
 
+const methodloc_regex = r"(?<sig>.+) in (?<mod>.+) at (?<loc>.+)$"
+
 function view(m::Method)
   str = sprint(show, "text/html", m)
-  str = replace(str, r" in .* at .*$" => "")
+  str = replace(str, methodloc_regex => s"\g<sig>")
   str = string("<span>", str, "</span>")
   tv, decls, file, line = Base.arg_decl_parts(m)
   HTML(str), file == :null ? "not found" : Atom.baselink(string(file), line)