Skip to content

Commit c86de28

Browse files
committed
remove timestamp input from create_entity
1 parent 6ee5741 commit c86de28

File tree

3 files changed

+3
-14
lines changed

3 files changed

+3
-14
lines changed

examples/02_entity_management.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,8 +79,7 @@ def create_entity_examples(j1):
7979
'createdBy': 'terraform',
8080
'lastBackup': '2024-01-01T00:00:00Z',
8181
'maintenanceWindow': 'sun:03:00-sun:04:00'
82-
},
83-
timestamp=int(time.time()) * 1000
82+
}
8483
)
8584
print(f"Created complex entity: {complex_entity['entity']['_id']}\n")
8685

examples/examples.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,7 @@
3737
entity_key='jupiterone-api-client-python:{}'.format(num1),
3838
entity_type='python_client_create_entity',
3939
entity_class='Record',
40-
properties=properties,
41-
timestamp=int(time.time()) * 1000 # Optional, defaults to current datetime
40+
properties=properties
4241
)
4342
print("create_entity()")
4443
print(create_r)
@@ -69,8 +68,7 @@
6968
entity_key='jupiterone-api-client-python:{}'.format(num2),
7069
entity_type='python_client_create_entity',
7170
entity_class='Record',
72-
properties=properties,
73-
timestamp=int(time.time()) * 1000 # Optional, defaults to current datetime
71+
properties=properties
7472
)
7573
print("create_entity()")
7674
print(create_r_2)

jupiterone/client.py

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -596,7 +596,6 @@ def create_entity(self, **kwargs: Any) -> Dict[str, Any]:
596596
entity_key (str): Unique key for the entity
597597
entity_type (str): Value for _type of entity
598598
entity_class (str): Value for _class of entity
599-
timestamp (int): Specify createdOn timestamp
600599
properties (dict): Dictionary of key/value entity properties
601600
"""
602601
# Validate required parameters
@@ -623,21 +622,14 @@ def create_entity(self, **kwargs: Any) -> Dict[str, Any]:
623622
if "properties" in kwargs and kwargs["properties"] is not None:
624623
self._validate_properties(kwargs["properties"])
625624

626-
# Validate timestamp if provided
627-
if "timestamp" in kwargs and kwargs["timestamp"] is not None:
628-
if not isinstance(kwargs["timestamp"], int) or kwargs["timestamp"] <= 0:
629-
raise JupiterOneClientError("timestamp must be a positive integer")
630625
variables = {
631626
"entityKey": kwargs.pop("entity_key"),
632627
"entityType": kwargs.pop("entity_type"),
633628
"entityClass": kwargs.pop("entity_class"),
634629
}
635630

636-
timestamp: int = kwargs.pop("timestamp", None)
637631
properties: Dict = kwargs.pop("properties", None)
638632

639-
if timestamp:
640-
variables.update(timestamp=timestamp)
641633
if properties:
642634
variables.update(properties=properties)
643635

0 commit comments

Comments
 (0)