Updating tests that previously expected throws.

Author: adam-in-ict

packages/integration-sdk-cli/src/__tests__/cli-run.test.ts

@@ -80,7 +80,8 @@ test('disables graph object schema validation', async () => {
   expect(process.env.ENABLE_GRAPH_OBJECT_SCHEMA_VALIDATION).toBeUndefined();
 });
 
-test('step should fail if enableSchemaValidation = true', async () => {
+test('step should warn if enableSchemaValidation = true', async () => {
+  const consoleSpy = jest.spyOn(console, 'warn');
   loadProjectStructure('instanceWithNonValidatingSteps');
   const job = generateSynchronizationJob();
 
@@ -101,26 +102,11 @@ test('step should fail if enableSchemaValidation = true', async () => {
   expect(log.displaySynchronizationResults).toHaveBeenCalledTimes(1);
 
   expect(log.displayExecutionResults).toHaveBeenCalledTimes(1);
-  expect(log.displayExecutionResults).toHaveBeenCalledWith({
-    integrationStepResults: [
-      {
-        id: 'fetch-users',
-        name: 'Fetch Users',
-        declaredTypes: ['my_user'],
-        partialTypes: [],
-        encounteredTypes: [],
-        status: StepResultStatus.FAILURE,
-      },
-    ],
-    metadata: {
-      partialDatasets: {
-        types: ['my_user'],
-      },
-    },
-  });
+  expect(consoleSpy).toHaveBeenCalled();
 });
 
-test('step should pass if enableSchemaValidation = false', async () => {
+test('step should pass and not warn if enableSchemaValidation = false', async () => {
+  const consoleSpy = jest.spyOn(console, 'warn');
   loadProjectStructure('instanceWithNonValidatingSteps');
   const job = generateSynchronizationJob();
 
@@ -159,6 +145,7 @@ test('step should pass if enableSchemaValidation = false', async () => {
       },
     },
   });
+  expect(consoleSpy).not.toHaveBeenCalled();
 });
 
 test('executes integration and performs upload', async () => {

packages/integration-sdk-cli/src/__tests__/cli.test.ts

@@ -199,30 +199,14 @@ describe('collect', () => {
       delete process.env.ENABLE_GRAPH_OBJECT_SCHEMA_VALIDATION;
     });
 
-    test('step should fail if enableSchemaValidation = true', async () => {
+    test('step should warn if enableSchemaValidation = true', async () => {
+      const consoleSpy = jest.spyOn(console, 'warn');
       await createCli().parseAsync(['node', 'j1-integration', 'collect']);
-
-      expect(log.displayExecutionResults).toHaveBeenCalledTimes(1);
-      expect(log.displayExecutionResults).toHaveBeenCalledWith({
-        integrationStepResults: [
-          {
-            id: 'fetch-users',
-            name: 'Fetch Users',
-            declaredTypes: ['my_user'],
-            partialTypes: [],
-            encounteredTypes: [],
-            status: StepResultStatus.FAILURE,
-          },
-        ],
-        metadata: {
-          partialDatasets: {
-            types: ['my_user'],
-          },
-        },
-      });
+      expect(consoleSpy).toHaveBeenCalled();
     });
 
-    test('step should pass if enableSchemaValidation = false', async () => {
+    test('step should pass and not warn if enableSchemaValidation = false', async () => {
+      const consoleSpy = jest.spyOn(console, 'warn');
       await createCli().parseAsync([
         'node',
         'j1-integration',
@@ -248,6 +232,7 @@ describe('collect', () => {
           },
         },
       });
+      expect(consoleSpy).not.toHaveBeenCalled();
     });
   });