🔀 : :: Person Icon 추가#9
Merged
Merged
Conversation
Closed
There was a problem hiding this comment.
Pull Request Overview
Adds a new Person icon to the central icon API and updates the example app to demonstrate it.
- Introduces
JusicoolIcon.personfactory method. - Illustrates usage of the new icon in the example app’s component screen.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/src/core/theme/icons/icons.dart | Added person icon constructor to JusicoolIcon. |
| example/lib/main.dart | Inserted JusicoolIcon.person() into the example screen layout. |
Comments suppressed due to low confidence (3)
lib/src/core/theme/icons/icons.dart:53
- [nitpick] Add a Dart doc comment for the
personmethod to maintain consistency with the other icon constructors and improve discoverability in IDEs.
static Widget person({
lib/src/core/theme/icons/icons.dart:59
- Ensure
person.svgis listed under theassets:section inpubspec.yamlso the asset is bundled and avoids missing-asset errors at runtime.
_buildIcon('person.svg',
lib/src/core/theme/icons/icons.dart:53
- Add a unit or widget test to cover the new
personicon, verifying the correct asset path and rendering behavior.
static Widget person({
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 개요
Person Icon 추가
📃 작업내용
Person Icon 추가
🔀 변경사항
🙋♂️ 질문사항
🍴 사용방법
🎸 기타