-
Notifications
You must be signed in to change notification settings - Fork 3
KDT0_ParkNAYoung LG U+ 홈페이지 클론코딩 (기존 PR closed 후) #75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
im-na0
wants to merge
47
commits into
main
Choose a base branch
from
KDT0_ParkNaYoung
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 43 commits
Commits
Show all changes
47 commits
Select commit
Hold shift + click to select a range
9857f16
Feat: "프로젝트 시작"
IAMISTP 2ae8410
Style: Header
im-na0 bdacb96
Feat: "header view 작업"
IAMISTP d52cb2e
Style: "header css작업"
IAMISTP 8f5fabe
Style: "img 추가"
IAMISTP 42de03b
Feat: "footer view 작업 , span 태그 -> a 태그로 변경"
IAMISTP ae870af
Style:"index.css 분리"
IAMISTP 5b6c632
Style:"a 태그로 수정"
IAMISTP 3ab097d
Style:"player css 작업"
IAMISTP 617e08f
Style: "player 에 필요한 icon 추가"
IAMISTP ee08431
Style: HTML CSS
im-na0 ecb18a0
Feat: "banner 구현 "
IAMISTP 5efd897
Style: "width 값 고정 제거"
IAMISTP 15e6aed
Style: "main css 분리"
IAMISTP 50d8f29
Style: "Banner css "
IAMISTP 5010ced
Style: "main 에 필요한 이미지 추가"
IAMISTP 68ef625
Feat: "매거진 view 작업 "
IAMISTP 86954b2
Feat: "main view 구현"
IAMISTP 0a013aa
Style: "main css 추가"
IAMISTP 7c6b5ba
Style: "배경색상 지정"
IAMISTP 19589cc
Style: "메인 view 구현에 필요한 이미지 추가 , 삭제"
IAMISTP 06e4ab1
Feat: "footer view 작업"
IAMISTP 3c42ea2
Style: "footer css 완료"
IAMISTP 95f944c
Style: "footer icon 추가"
IAMISTP 3acd1f1
Feat: HTML CSS JS 추가
im-na0 c7a1f38
Design: CSS 수정
im-na0 4e905ba
Feat: "메인 슬라이드 기능구현_view 작업"
IAMISTP 0f6d227
Style: "main 슬라이드 기능구현_css"
IAMISTP 662ba1d
Feat: "main 슬라이드 기능구현_javascript"
IAMISTP e350f9f
Style: "슬라이드 요소 이미지 추가 , icon 추가"
IAMISTP 6896fbe
Fix: "요소 class명 변경 , 컨텐츠 내용 변경"
IAMISTP 0101229
Style: "메인 요소 hover 시 underline 추가"
IAMISTP cfa15d4
Fix: "오디오 바 view 수정"
IAMISTP 7196516
Style: "오디오 바 스타일 설정"
IAMISTP 0ba56a2
Feat: "오디오바 기능구현"
IAMISTP 4becc4d
Fix: "title 명 변경"
IAMISTP 9c4ae90
Docs: ReadMe.md 작성
im-na0 6f54d7a
Merge pull request #51 from KDT1-FE/KDT0_hyeminpark
IAMISTP f793ce2
Fix: error
im-na0 f23f9e3
Docs: ReadMe.md 작성
im-na0 ea0305a
Fix: Error
im-na0 692ea60
Fix: commite history
im-na0 f378a3a
Fix: Error
im-na0 d42caf9
Docs: ReadMe.md 수정
im-na0 a6807c8
Docs: Apply .gitignore
im-na0 dce9f9d
Feat: 오늘 하루 그만 보기 기능추가
im-na0 c11d30a
Feat: 오늘 하루 그만보기 기능 수정
im-na0 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| { | ||
| "recommendations": [ | ||
| "esbenp.prettier-vscode" | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,45 +1,30 @@ | ||
| [참고 내용] | ||
| # LG U+ 홈페이지 클론코딩 | ||
|
|
||
| 👀 자신이 원하는 사이트 레이아웃 클론 | ||
| 원하는 사이트(페이지)를 자유롭게 선택하고 레이아웃을 클론 코딩하세요. | ||
| 평소에 도전해 보고 싶었거나 혹은 자신의 수준에 맞는 사이트(페이지)를 선택하세요. | ||
| 과제 수행 및 리뷰 기간은 별도 공지를 참고하세요! | ||
| #### 기간 | ||
|
|
||
| 과제 수행 및 제출 방법 | ||
| 2023-07-24 ~ 2023-07-28 | ||
|
|
||
| 1. 현재 저장소를 로컬에 클론(Clone)합니다. | ||
| 2. 자신의 본명으로 브랜치를 생성합니다.(구분 가능하도록 본명을 꼭 파스칼케이스로 표시하세요, git branch KDT0_이름) | ||
| 3. 자신의 본명 브랜치에서 과제를 수행합니다. | ||
| 4. 과제 수행이 완료되면, 자신의 본명 브랜치를 원격 저장소에 푸시(Push)합니다.(main 브랜치에 푸시하지 않도록 꼭 주의하세요, git push origin KDT0_이름) | ||
| 5. 저장소에서 main 브랜치를 대상으로 Pull Request 생성하면, 과제 제출이 완료됩니다!(E.g, main <== KDT0_이름) | ||
| --- | ||
|
|
||
| #### 프로젝트 내용 | ||
|
|
||
| - main 혹은 다른 사람의 브랜치로 절대 병합하지 않도록 주의하세요! | ||
| - Pull Request에서 보이는 설명을 다른 사람들이 이해하기 쉽도록 꼼꼼하게 작성하세요! | ||
| - Pull Request에서 과제 제출 후 절대 병합(Merge)하지 않도록 주의하세요! | ||
| - 과제 수행 및 제출 과정에서 문제가 발생한 경우, 바로 담당 멘토나 강사에서 얘기하세요! | ||
| 레퍼런스 : https://www.lguplus.com/ | ||
| <br> 데모 : https://glowing-chebakia-807feb.netlify.app/ | ||
|
|
||
| 필수 요구사항 | ||
| --- | ||
|
|
||
| - 과제에 대한 설명을 포함한 README.md 파일을 제공하세요! | ||
| - 과제 결과와 비교할 수 있는 실제 사이트(페이지)의 주소를 명시하세요! | ||
| - 과정에서 사용한 프로젝트 폴더/파일이 모두 포함돼야 합니다, 일부 파일만 제출하지 마세요! | ||
| - 실제 서비스로 배포하고 접근 가능한 링크를 추가해야 합니다. | ||
| #### 기능구현 | ||
|
|
||
| 선택 요구사항 | ||
| - 시멘틱 태그를 활용했습니다 | ||
| - flex를 이용했습니다 | ||
| - JS로 애니메이션을 추가했습니다 | ||
| - Swiper를 이용해 슬라이드를 기능을 추가했습니다 | ||
|
|
||
| - < header >, < section > 등 시멘틱 태그를 최대한 활용해보세요. | ||
| - 실제 사이트의 레거시 코드 활용보단 최신의 CSS Flex 혹은 Grid 등을 활용해보세요. | ||
| - 부분적으로 BEM 방법론을 도입해보세요. | ||
| - JS가 필요한 부분은 되도록 생략하되 이유를 명시해보세요.(CSS로 대체 가능한지 피드백이 있을 수 있겠죠?!) | ||
| - JS가 필요한 부분 중 구현할 부분이 있다면 자유롭게 구현해보세요.(JS 과제가 아니니까 가볍게 구현하시길 추천해요) | ||
| --- | ||
|
|
||
| 손쉬운 이미지 추출 방법 | ||
| #### 아쉬운점 | ||
|
|
||
| 사이트 클론에 필요한 이미지를 좀 더 쉽게 추출하기 위해서 Chrome 확장 프로그램인 Image Downloader를 사용하세요. | ||
|
|
||
| 1. 원하는 사이트 접속 | ||
| 2. Image Downloader 확장 프로그램 실행 | ||
| 3. 다운로드 원하는 이미지 선택 | ||
| 4. 서브 폴더 이름(Save to subfolder) 명시 | ||
| 5. 다운로드! | ||
| - 반응형을 고려하지 못했습니다 | ||
| - class를 과도하게 사용했습니다 | ||
| - scrollTop 기능을 구현하지 못했습니다 | ||
| - 이중 Swiper를 controll하는 부분을 구현하지 못했습니다 |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이런 OS가 생성한 파일은 커밋되지 않도록
.gitignore에 추가해주시는 게 좋습니다!