Skip to content

Commit 03bbefa

Browse files
committed
fix(rebase): resolve build errors from rebase conflict resolution
Corrects merge artifacts introduced while rebasing the TurboQuant feature branch onto upstream master: - ggml.c: bump GGML_OP_COUNT static_assert 97 -> 98 (GGML_OP_TURBO_WHT added to the op enum; arrays already carry the entry, the count literal was left at master's value during the merge). - llama.h / common.h: drop duplicate n_outputs_max field (the fork adds it, master already has it); keep master's "max outputs in a batch" field and ordering. - llama-context.cpp: drop the matching duplicate n_outputs_max initializer. - llama-vocab.h: drop duplicate get_suppress_tokens() declaration. - mtmd/models.h + clip.cpp: drop duplicate clip_graph_gemma4uv struct and the duplicate PROJECTOR_TYPE_GEMMA4UA case (master already carries gemma4 vision). - models/step35.cpp: restore upstream's complete file (no turbo content; the conflict resolution had dropped its MTP block, leaving trunk_flags undefined). CPU-only build of libllama, llama-server, llama-cli and llama-quantize passes. https://claude.ai/code/session_01HZZQMPA6D6KWgcuDsDarWa
1 parent 902c32e commit 03bbefa

8 files changed

Lines changed: 289 additions & 22 deletions

File tree

common/common.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -431,7 +431,6 @@ struct common_params {
431431
int32_t n_keep = 0; // number of tokens to keep from initial prompt
432432
int32_t n_chunks = -1; // max number of chunks to process (-1 = unlimited)
433433
int32_t n_parallel = 1; // number of parallel sequences to decode
434-
int32_t n_outputs_max = 0; // max outputs supported by the context (0 = derive)
435434
int32_t n_sequences = 1; // number of sequences to decode
436435
int32_t n_outputs_max = 0; // max outputs in a batch (0 = n_batch)
437436
int32_t grp_attn_n = 1; // group-attention factor

ggml/src/ggml.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1122,7 +1122,7 @@ static const char * GGML_OP_NAME[GGML_OP_COUNT] = {
11221122
"GLU",
11231123
};
11241124

1125-
static_assert(GGML_OP_COUNT == 97, "GGML_OP_COUNT != 97");
1125+
static_assert(GGML_OP_COUNT == 98, "GGML_OP_COUNT != 98");
11261126

11271127
static const char * GGML_OP_SYMBOL[GGML_OP_COUNT] = {
11281128
"none",
@@ -1234,7 +1234,7 @@ static const char * GGML_OP_SYMBOL[GGML_OP_COUNT] = {
12341234
"glu(x)",
12351235
};
12361236

1237-
static_assert(GGML_OP_COUNT == 97, "GGML_OP_COUNT != 97");
1237+
static_assert(GGML_OP_COUNT == 98, "GGML_OP_COUNT != 98");
12381238

12391239
static_assert(GGML_OP_POOL_COUNT == 2, "GGML_OP_POOL_COUNT != 2");
12401240

include/llama.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -340,7 +340,6 @@ extern "C" {
340340
uint32_t n_batch; // logical maximum batch size that can be submitted to llama_decode
341341
uint32_t n_ubatch; // physical maximum batch size
342342
uint32_t n_seq_max; // max number of sequences (i.e. distinct states for recurrent models)
343-
uint32_t n_outputs_max; // max outputs supported by the context (0 = derive from n_seq_max)
344343
uint32_t n_rs_seq; // number of recurrent-state snapshots per seq for rollback (0 = no rollback) [EXPERIMENTAL]
345344
uint32_t n_outputs_max; // max outputs in a ubatch (0 = n_batch)
346345
int32_t n_threads; // number of threads to use for generation

src/llama-context.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3447,7 +3447,6 @@ llama_context_params llama_context_default_params() {
34473447
/*.n_batch =*/ 2048,
34483448
/*.n_ubatch =*/ 512,
34493449
/*.n_seq_max =*/ 1,
3450-
/*.n_outputs_max =*/ 0,
34513450
/*.n_rs_seq =*/ 0,
34523451
/*.n_outputs_max =*/ 0,
34533452
/*.n_threads =*/ GGML_DEFAULT_N_THREADS, // TODO: better default

src/llama-vocab.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -151,8 +151,6 @@ struct llama_vocab {
151151

152152
const std::vector<llama_token> & get_suppress_tokens() const;
153153

154-
const std::vector<llama_token> & get_suppress_tokens() const;
155-
156154
int max_token_len() const;
157155

158156
int find_bpe_rank(const std::string & token_left, const std::string & token_right) const;

src/models/step35.cpp

Lines changed: 287 additions & 2 deletions
Large diffs are not rendered by default.

tools/mtmd/clip.cpp

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1629,14 +1629,6 @@ struct clip_model_loader {
16291629
hparams.eps = 1e-6f;
16301630
hparams.n_mel_bins = 640;
16311631
} break;
1632-
case PROJECTOR_TYPE_GEMMA4UA:
1633-
{
1634-
// Encoder-free: raw 16 kHz waveform chunked into 640-sample frames.
1635-
hparams.audio_chunk_len = 0;
1636-
hparams.audio_sample_rate = 16000;
1637-
hparams.eps = 1e-6f;
1638-
hparams.n_mel_bins = 640;
1639-
} break;
16401632
case PROJECTOR_TYPE_GRANITE_SPEECH:
16411633
{
16421634
hparams.audio_chunk_len = 0;

tools/mtmd/models/models.h

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,11 +24,6 @@ struct clip_graph_gemma4uv : clip_graph {
2424
ggml_cgraph * build() override;
2525
};
2626

27-
struct clip_graph_gemma4uv : clip_graph {
28-
clip_graph_gemma4uv(clip_ctx * ctx, const clip_image_f32 & img) : clip_graph(ctx, img) {}
29-
ggml_cgraph * build() override;
30-
};
31-
3227
struct clip_graph_pixtral : clip_graph {
3328
clip_graph_pixtral(clip_ctx * ctx, const clip_image_f32 & img) : clip_graph(ctx, img) {}
3429
ggml_cgraph * build() override;

0 commit comments

Comments
 (0)