RSS Overhaul#320
Conversation
|
Download the artifacts for this pull request: |
| // inconsistent orbital elements. | ||
|
|
||
| !Body,* {} | ||
| !Body,*{} |
There was a problem hiding this comment.
This bothered me when I saw it. Still does. It is critical that this patch runs before all other patches that add a Body node. Previously it relied on the lexicographical ordering: RealSolarSystem/RSSKopernicusSettings.cfg before RealSolarSystem/RSSKopernicus/. The "/" sorting after A-Z.
You don't have that pattern now. You have Config/RSS_Kopernicus.cfg compared with Config/Earth/. I didn't think MM patch ordering had a file-before-folder pattern, I thought it was strictly lexicographical.
My suggestion is move this patch to BEFORE[RealSolarSystem], making it clear and giving you a more obvious sorting of this setup patch versus the global ones.
There was a problem hiding this comment.
That is a very valid point and it should be a BEFORE pass even without name shorting (stock KSP mods use AFTER[Kopernicus] for example).
There was a problem hiding this comment.
As of 2239a63 a better MM is implementated. The new pass allows base RSS patches (celestial bodies), RSS general patches (CommNet etc) and RSS compatibility patches to coexist without conflicts.
|
If anyone around here is knownledgable about how textures are set up for use in KSP please do chime in. The terrain detail textures RSS includes have a very shiny-like, almost glossy appearance, which is...suboptimal. |
|
As weird as it sounds, no! 100% drop-in replacement. Well, the Titan body configuration had a duplicate GM factor with less precision that overrode the proper one so there might be a very slight difference in the orbit (8.978138376543E+12 vs 8.9778648E+12, 0.00305%). Edit 1: I could make a save-breaking change by reordering the body indices. Edit 2: OK, I will break saves, I corrected the height offset of Vesta and Ceres when transitioning between PQS/SS (any landed vessels will float above the surface). |
|
If it is save breaking, then AssemblyInfo.cs can/should probably be updated as well. It's still reading 18.5.0.0! |
|
I guess so, I am not well-versed with the C# side of KSP and mods (and should be done in a separate commit). |
|
Poll: since there will be some save-breaking changes, would this be a good opportunity to remove all "flightGlobalsIndex" definitions? |
|
There's different levels of save breakage. Pretty much nobody's going to care about vessels landed on Ceres. However every probe around every body getting deleted is a serious issue. |
|
For the above changes add the following textures: https://github.com/PhineasFreak/RSS-Textures-Dev/releases/tag/v0.1.0 Select your pack according to the already installed RSS textures. Replace when asked. |
|
All my landed Moon and Mars vessels have survived. Various probes also appear to be on their intended course. |
|
How is Kopernicus handling the CB cache files after an update? I know that they are auto-generated upon first run but they will be outdated if anything is modified in their configuration files afterwards. Does CKAN handle the whole shebang of deleting the .bin files? |
|
Needs this too: KSP-RO/RSS-CanaveralHD#7 |
|
Regarding the removal of the support for the "FinalFrontier" mod, is it planned in RP-1 to have it still in or even a specific replacement? |
|
@Clayell Have you tried compatibilty with the above mods? Most of the listed references are a no-issue. Mods that 100% need to be updated for the new CB name:
|
|
@Gordon-Dry If FinalFrontier support is something that is desired still (I had never heard of that mod before or seen anyone use it in the context of KSP-RO) it is easy to reinstate it. |
|
I'm also a final frontier enjoyer, but I would not mind the built-in support budding off into its own separate install if it makes long term maintenance simpler. (Worst case scenario I can just grab the previous release files and add them back locally) |
|
If the Final Frontier support is taken from RSS it could be (properly) implemented into RP-1, away from the stockish style to a more RP-ish style. |
- Reduce probability for all families. - Change SMA and inclination values to be representative of the "core" of the asteroid belts. - Add Kuiper Belt asteroids.
|
RP-1 does not really need FF, the milestones + Historian-like screenshots are sufficient (IMO). Besides, how many players have managed to get further than crewed Mars missions? Even uncrewed landings are few and far between. I will reinstate FF later today (it has been updated for the new directory structure). Unfortunately FF does not natively support DDS textures so they will remain in PNG format. |
|
Ohhhh. In that case I think we can move those pngs to plugindata so that KSP doesn't automatically touch them? |
- Added ribbons for Eris.
- Manually define the PQS/SS transition altitudes to reduce visual PQS tiling. - Change the SS texture color to be a bit more muted.
|
Hmm, I did not check whether FF can load the textures from PluginData but it is a very old mod and I do not expect that it can load them "on demand". Texture loader source is here (will not comment since I cannot "read" C#): https://github.com/Nereid42/FinalFrontier/blob/1.9.x/src/util/ImageLoader.cs |
|
Looks like FF should be able to load assets from anywhere in gamedata. At least as long as |
Oceans are loaded independently of PQS mods. Kopernicus has a "removeOcean" option to disable them but changing the CB template is cleaner.
- Convert some missed colors to RGBA. - Set more accurate ring inner and outer multipliers.
- Remove the custom CB cache files, allow Kopernicus to handle their generation and updating when any of the CB patches is modified. - Fix the detail texture limits to be inside the -1/+1 range. - Increase the detail tiling factor for all CBs that use the "Vall" built-in textures. - Customize some of the detail texture transition levels. - Re-enable the oblateness of the gas giants. - Tweak the PQS colors of Phobos, Deimos and Vesta to better match the SS colors. - Switch Triton rotation to be tidally locked to Neptune. - More color conversions to RGBA() macro.
These mostly follow the stock KSP convention of PQS terrain quality settings to reduce height map artifacts, especially noticeable in smaller CBs (Phobos, Deimos, Ceres, Vesta) as "staircases".
Mod does not appear to work and KSPCF complains about it for causing memory leaks.
Not sure if necessary but newer Kopernicus mods include that parameter.
- Fix "underwater" fog gradient. - Improve ocean animation and fade-out effects. - Tweak Titan PQS aerial fading and SS rim intensity.
6 participants
Major update for RSS to try and bring it up to current KSP and Kopernicus standards:
Bug Fixes:
Known Issues:
Other Notes: