Fix tests

Author: drewcassidy

KSPCommon.props

@@ -47,7 +47,8 @@
   <PropertyGroup>
     <!-- The root directory of the mod, the folder that gets placed in GameData -->
     <KSPModRoot Condition=" '$(KSPModRoot)' == '' ">$(ProjectDir)/../GameData/$(ProjectName)/</KSPModRoot>
-    <KSPModPluginFolder Condition=" '$(KSPModPluginFolder)' == '' ">$(KSPModGameData)/Plugins/</KSPModPluginFolder>
+    <!-- The folder to place resulting DLLs into, relative to KSPModRoot -->
+    <KSPModPluginFolder Condition=" '$(KSPModPluginFolder)' == '' "/>
   </PropertyGroup>
 
   <!-- Import the csproj.user file. -->

KSPCommon.targets

@@ -29,8 +29,8 @@
       <BinariesToCopy Include="$(TargetDir)/**/*.dll"/>
       <BinariesToCopy Include="$(TargetDir)/**/*.pdb" Condition="'$(Condition)' == 'Debug'"/>
     </ItemGroup>
-    <MakeDir Directories="$(KSPModPluginFolder)"/>
-    <Copy SourceFiles="@(BinariesToCopy)" DestinationFolder="$(KSPModPluginFolder)/%(RecursiveDir)"/>
+    <MakeDir Directories="$(KSPModRoot)/$(KSPModPluginFolder)"/>
+    <Copy SourceFiles="@(BinariesToCopy)" DestinationFolder="$(KSPModRoot)/$(KSPModPluginFolder)/%(RecursiveDir)"/>
   </Target>
 
   <!-- Use CKAN to install mods for any references tagged with a CKAN Identifier -->

tests/plugin-mod-legacy/PluginModLegacy/plugin-mod-legacy.csproj

@@ -50,10 +50,6 @@
     <ErrorReport>prompt</ErrorReport>
     <CodeAnalysisRuleSet>MinimumRecommendedRules.ruleset</CodeAnalysisRuleSet>
   </PropertyGroup>
-  <PropertyGroup>
-    <RepoRootPath>$(MSBuildThisFileDirectory)../</RepoRootPath>
-    <BinariesOutputRelativePath>GameData/plugin-mod-legacy</BinariesOutputRelativePath>
-  </PropertyGroup>
   <Import Project="$(MSBuildExtensionsPath)/$(MSBuildToolsVersion)\Microsoft.Common.props" />
   <Import Project="$(MSBuildThisFileDirectory)../../../KSPCommon.targets" />
   <Import Project="$(MSBuildBinPath)/Microsoft.CSharp.targets" />

tests/plugin-mod-nuget/plugin-mod.csproj

@@ -22,8 +22,6 @@
     <NoWarn>1701;1702;CS0649;CS1591;</NoWarn>
     <AssemblyCopyright>2024 KSPModdingLibs Contributors</AssemblyCopyright>
     <AssemblyName>PluginModNuget</AssemblyName>
-    <KSPModRoot>$(MSBuildThisFileDirectory)GameData/plugin-mod-nuget/</KSPModRoot>
-    <KSPModPluginFolder>$(KSPModRoot)/</KSPModPluginFolder>
   </PropertyGroup>
 
   <!-- DLL Dependencies-->

tests/plugin-mod/plugin-mod.csproj

@@ -17,8 +17,6 @@
     <NoWarn>1701;1702;CS0649;CS1591;</NoWarn>
     <AssemblyCopyright>2024 KSPModdingLibs Contributors</AssemblyCopyright>
     <AssemblyName>PluginMod</AssemblyName>
-    <KSPModRoot>$(MSBuildThisFileDirectory)GameData/plugin-mod/</KSPModRoot>
-    <KSPModPluginFolder>$(KSPModRoot)/</KSPModPluginFolder>
   </PropertyGroup>
 
   <!-- DLL Dependencies-->