KSPBurst emits warnings about being unable to resolve assemblies

[swlynch99]

With KSPBurst 1.7.4.1 I see the following warnings in the log

Warning: Failed to resolve assembly: 'Scale_Redist, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null'
Warning: Failed to resolve assembly: 'RealFuels, Version=15.3.1.0, Culture=neutral, PublicKeyToken=null'
Warning: Failed to resolve assembly: 'RealFuels, Version=15.3.1.0, Culture=neutral, PublicKeyToken=null'
Warning: Failed to resolve assembly: 'VesselViewPlugin, Version=0.8.9.0, Culture=neutral, PublicKeyToken=null'
Warning, Unable to load definition for type TweakScale.IRescalable`1<ferram4.FARWingAerodynamicModel>. Skipping it. Reason: Unable to resolve type `TweakScale.IRescalable`1<ferram4.FARWingAerodynamicModel>. Reason: Failed to resolve assembly: 'Scale_Redist, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null'`
Warning, Unable to load definition for type TweakScale.IRescalable`1<FerramAerospaceResearch.FARPartGeometry.GeometryPartModule>. Skipping it. Reason: Unable to resolve type `TweakScale.IRescalable`1<FerramAerospaceResearch.FARPartGeometry.GeometryPartModule>. Reason: Failed to resolve assembly: 'Scale_Redist, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null'`
Warning, Unable to load definition for type TweakScale.IRescalable`1<ferram4.FARWingAerodynamicModel>. Skipping it. Reason: Unable to resolve type `TweakScale.IRescalable`1<ferram4.FARWingAerodynamicModel>. Reason: Failed to resolve assembly: 'Scale_Redist, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null'`
Warning, Unable to load definition for type TweakScale.IRescalable`1<FerramAerospaceResearch.FARPartGeometry.GeometryPartModule>. Skipping it. Reason: Unable to resolve type `TweakScale.IRescalable`1<FerramAerospaceResearch.FARPartGeometry.GeometryPartModule>. Reason: Failed to resolve assembly: 'Scale_Redist, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null'`

As far as I can tell these are currently harmless because none of the types specified have [BurstCompile] annotations. I'm not sure if this is exposing an underlying problem that should be fixed, though.

Here are all the relevant logs (KSP.log also included in the KSPBurst folder)
KSPBurst.zip

[JonnyOThan]

The Scale_Redist one is interesting because 1.0.0.0 is not the correct version of Tweakscale redist.

[JonnyOThan]

FAR is just wrong. https://github.com/dkavolis/Ferram-Aerospace-Research/blob/c769cbd3d23ec9fd22538c1eb8b57fd2fcd025c6/FerramAerospaceResearch/FerramAerospaceResearch.csproj#L72

[JonnyOThan]

I think they're not harmless at all; it seems to completely prevent burst from working.

Warning: Failed to resolve assembly: 'Scale_Redist, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null'
Warning: Failed to resolve assembly: 'RealFuels, Version=15.3.1.0, Culture=neutral, PublicKeyToken=null'
Warning: Failed to resolve assembly: 'RealFuels, Version=15.3.1.0, Culture=neutral, PublicKeyToken=null'
Warning: Failed to resolve assembly: 'VesselViewPlugin, Version=0.8.9.0, Culture=neutral, PublicKeyToken=null'
Unexpected exception while collecting types in assembly `FerramAerospaceResearch, Version=0.16.1.2, Culture=neutral, PublicKeyToken=null`

[ERR 22:17:33.834] [KSPBurst]: Burst stderr:
Mono.Cecil.AssemblyResolutionException: Failed to resolve assembly: 'Scale_Redist, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null'
   at Mono.Cecil.BaseAssemblyResolver.Resolve(AssemblyNameReference name, ReaderParameters parameters)
   at zzzUnity.Burst.CodeGen.AssemblyResolver.Resolve(AssemblyNameReference name)
   at Burst.Compiler.IL.AssemblyLoader.Resolve(AssemblyNameReference name)
   at Mono.Cecil.MetadataResolver.Resolve(TypeReference type)
   at Mono.Cecil.TypeReference.Resolve()
   at Burst.Bcl.BclApp.CollectGenericTypeInstances(TypeReference type, List`1 types, HashSet`1 visited)
   at Burst.Bcl.BclApp.CollectGenericTypeInstances(AssemblyDefinition assembly, List`1 types, HashSet`1 visited)
   at Burst.Bcl.BclApp.FindExecuteMethods(List`1 rootAssemblyPaths, Boolean includeRootAssemblyReferences)


[ERR 22:17:33.834] [KSPBurst]: Burst compiler had errors

[ERR 22:17:33.834] [KSPBurst]: Burst did not generate a library

[ERR 22:17:33.834] [KSPBurst]: Burst compiler exited with a non-zero exit code: 1

[JonnyOThan]

And it looks like this is happening on the current version of KSPBurst too; it's just not complaining as loudly about it.

[JonnyOThan]

I think we're going to have to make an exclusion list to avoid feeding these assemblies to the compiler.

[Phantomical]

With #17 I'm going to consider this resolved. We only build DLLs that explicitly have a KSPAssemblyDependency on KSPBurst or are otherwise marked by declaring a KSPBURST_ASSEMBLY config node. In the future if other DLLs cause this problem then there is also a method to disable them entirely.

[Tartrus1]

I am still recieving this error and the burst compiler is not active. I also added the KSP burst assembly arguments as shown in issue 17 but same result. Looking into the argfile.txt in the plugindata folder, I see that the plugin is still loading in Ferram "--assembly-folder=GameData\FerramAerospaceResearch\Plugins"

[Phantomical]

Could you send your KSP.log? Also are you using a custom version of FAR?

[Phantomical]

https://drive.google.com/drive/folders/1w3IljxVFfHr8ishg_PWMu1NQ5wQ3zfqA?usp=sharing

Just the CKAN version of FAR.

For some reason I can't download that file.

[Tartrus1]

https://drive.google.com/drive/folders/1w3IljxVFfHr8ishg_PWMu1NQ5wQ3zfqA?usp=sharing
Just the CKAN version of FAR.

For some reason I can't download that file.

Does this link work?
https://drive.google.com/drive/folders/1bceQK4PFSfoC1qFcP2PXlellwJKiPM_n?usp=sharing

[Phantomical]

My best guess is that ChrisGNCSuite depends on FARc and that's causing it to be pulled in by the burst compiler, which ends up breaking everything.

Short of FARc being fixed I don't think there's really anything I can do here.

[ChrisInBed]

My best guess is that ChrisGNCSuite depends on FARc and that's causing it to be pulled in by the burst compiler, which ends up breaking everything.

Short of FARc being fixed I don't think there's really anything I can do here.

Hi, I am the author of ChrisGNCSuite. Sorry I am not very familiar with Burst Compiler and still confused why it is causing the issue. I only use [BurstCompile] to accelerate the trajectory integrator, and it has nothing to do with FARc calculations. I want to know:

1. Is this issue blocking all DLLs from Burst compiler, or just FARc and ChrisGNCSuite (kOS-AFS)?
2. Since there is little chance we can do something to FARc, I want to solve this problem in ChrisGNCSuite. What should I do?