review feedback on PR #412, round 2

Two more review comments:

- Restore the `make_const!` macro in `visualizer::proportion_bar`.
  The matcher syntax (`$name:ident = $content:literal`) is now
  silenced by perfectionist `93cb529`'s extension of
  `looks_like_expression` to top-level `=` markers; adding
  `make_const` to `allow_extra` covers the residual unknown-macro
  flag from `AllowAndDeny` mode.
- Drop the experiment with `perfectionist::non_exhaustive_error`.
  Remove the deny directive at the crate root, and remove the
  `#[cfg_attr(... expect(perfectionist::non_exhaustive_error,
  ...))]` suppressions added on `args::fraction::ConversionError`
  and `args::fraction::FromStrError` in the previous commit
  (those types are explicitly exhaustive, so the rule was telling
  them to add `#[non_exhaustive]` they did not want; the right
  resolution is to drop the rule, not work around it).

https://claude.ai/code/session_01CoRidYHvni9nKNgxMPXmfQ

Author: claude

dylint.toml

@@ -21,7 +21,7 @@ prefix = [
 
 ["perfectionist::macro_argument_binding"]
 deny_extra = ["debug_assert_op", "debug_assert_op_expr"]
-allow_extra = ["bump", "link", "symlink", "test_case", "visualize"]
+allow_extra = ["bump", "link", "make_const", "symlink", "test_case", "visualize"]
 
 ["perfectionist::single_letter_closure_param"]
 comparison_methods = ["sort_by", "sort_unstable_by", "sort_by_key", "sort_unstable_by_key", "min_by", "max_by", "min_by_key", "max_by_key", "binary_search_by", "binary_search_by_key", "cmp_by", "partial_cmp_by", "eq_by", "fold", "sort_reflection_by", "into_sorted_by"]

src/args/fraction.rs

@@ -11,13 +11,6 @@ pub struct Fraction(f32);
 
 /// Error that occurs when calling [`Fraction::new`].
 #[derive(Debug, Display, Error, Clone, Copy, PartialEq, Eq)]
-#[cfg_attr(
-    dylint_lib = "perfectionist",
-    expect(
-        perfectionist::non_exhaustive_error,
-        reason = "this error type is explicitly exhaustive: `Fraction::new` can only fail in the two ways enumerated below, and any future failure mode would be a `Fraction::new` API change worth a SemVer-major bump",
-    )
-)]
 pub enum ConversionError {
     /// Provided value is greater than or equal to 1.
     #[display("greater than or equal to 1")]
@@ -50,13 +43,6 @@ impl TryFrom<f32> for Fraction {
 
 /// Error that occurs when parsing a string as [`Fraction`].
 #[derive(Debug, Display, Error, Clone, PartialEq, Eq)]
-#[cfg_attr(
-    dylint_lib = "perfectionist",
-    expect(
-        perfectionist::non_exhaustive_error,
-        reason = "this error type is explicitly exhaustive: `Fraction::from_str` can only fail in the two ways enumerated below, and any future failure mode would be a `Fraction::from_str` API change worth a SemVer-major bump",
-    )
-)]
 pub enum FromStrError {
     ParseFloatError(ParseFloatError),
     Conversion(ConversionError),

src/lib.rs

@@ -6,10 +6,6 @@
 #![deny(warnings)]
 #![cfg_attr(dylint_lib = "perfectionist", feature(register_tool))]
 #![cfg_attr(dylint_lib = "perfectionist", register_tool(perfectionist))]
-#![cfg_attr(
-    dylint_lib = "perfectionist",
-    deny(perfectionist::non_exhaustive_error)
-)]
 
 #[cfg(feature = "json")]
 pub use serde;

src/visualizer/proportion_bar.rs

@@ -7,11 +7,17 @@ use std::fmt::{Display, Error, Formatter};
 #[derive(Debug, Display, Clone, Copy, PartialEq, Eq, AsRef, Deref, Into)]
 pub struct ProportionBarBlock(char);
 
-pub const LEVEL0_BLOCK: ProportionBarBlock = ProportionBarBlock('█');
-pub const LEVEL1_BLOCK: ProportionBarBlock = ProportionBarBlock('▓');
-pub const LEVEL2_BLOCK: ProportionBarBlock = ProportionBarBlock('▒');
-pub const LEVEL3_BLOCK: ProportionBarBlock = ProportionBarBlock('░');
-pub const LEVEL4_BLOCK: ProportionBarBlock = ProportionBarBlock(' ');
+macro_rules! make_const {
+    ($name:ident = $content:literal) => {
+        pub const $name: ProportionBarBlock = ProportionBarBlock($content);
+    };
+}
+
+make_const!(LEVEL0_BLOCK = '█');
+make_const!(LEVEL1_BLOCK = '▓');
+make_const!(LEVEL2_BLOCK = '▒');
+make_const!(LEVEL3_BLOCK = '░');
+make_const!(LEVEL4_BLOCK = ' ');
 
 /// Proportion bar.
 #[derive(Debug, Clone, Copy, PartialEq, Eq, From, Into)]