Skip to content

fix(test): parse BUILD_FLAGS and TEST_FLAGS #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KSXGitHub merged 2 commits into from
Mar 24, 2026
Merged

fix(test): parse BUILD_FLAGS and TEST_FLAGS #371

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d160cce
refactor(test): replace eval with bash arrays in unit function
claude Mar 24, 2026
37d8705
fix(test): handle empty arrays under nounset on older bash
claude Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,10 +54,12 @@ run_if() (
)

unit() (
eval run_if "${LINT:-true}" cargo clippy "$@" -- -D warnings
eval run_if "${DOC:-false}" cargo doc "$@"
eval run_if "${BUILD:-true}" cargo build "${BUILD_FLAGS:-}" "$@"
eval run_if "${TEST:-true}" cargo test "${TEST_FLAGS:-}" "$@"
read -ra build_flags <<<"${BUILD_FLAGS:-}"
read -ra test_flags <<<"${TEST_FLAGS:-}"
Comment thread
KSXGitHub marked this conversation as resolved.
run_if "${LINT:-true}" cargo clippy "$@" -- -D warnings
run_if "${DOC:-false}" cargo doc "$@"
run_if "${BUILD:-true}" cargo build ${build_flags[@]+"${build_flags[@]}"} "$@"
run_if "${TEST:-true}" cargo test ${test_flags[@]+"${test_flags[@]}"} "$@"
)

run_if "${FMT:-true}" cargo fmt -- --check
Expand Down
Loading