docs(ai): no longer tell AIs to disable "fail fast"#374
Merged
Conversation
The fail-fast default is better for iterative AI agent workflows where speed matters. The TEST_SKIP hints already handle environment-specific test failures, making the no-fail-fast recommendation unnecessary. The PDU_NO_FAIL_FAST option remains available in test.sh for CI and manual use. https://claude.ai/code/session_01Ptkb3AMQSEjH5P2MRYcF88
Performance Regression Reportscommit: e60672b There are no regressions. |
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the recommendation to set PDU_NO_FAIL_FAST=true from the repository’s AI instruction docs/templates, aligning the guidance with a faster default fail-fast workflow while keeping the env var supported by test.sh.
Changes:
- Removed the
PDU_NO_FAIL_FAST=truerecommendation from the shared AI-instructions template. - Regenerated/updated the derived instruction documents (CLAUDE.md, AGENTS.md, and .github/copilot-instructions.md) accordingly.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| template/ai-instructions/shared.md | Drops the PDU_NO_FAIL_FAST recommendation from the shared AI instructions template. |
| CLAUDE.md | Removes the same recommendation from the Claude-specific generated instructions. |
| AGENTS.md | Removes the same recommendation from the agent instructions doc. |
| .github/copilot-instructions.md | Removes the same recommendation from GitHub Copilot instructions. |
KSXGitHub
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://claude.ai/code/session_01Ptkb3AMQSEjH5P2MRYcF88