Skip to content

ci(deploy): tighten tag filter to digit-led version segments#381

Merged
KSXGitHub merged 2 commits into
masterfrom
copilot/update-deploy-yaml-version-matching
Mar 28, 2026
Merged

ci(deploy): tighten tag filter to digit-led version segments#381
KSXGitHub merged 2 commits into
masterfrom
copilot/update-deploy-yaml-version-matching

Conversation

Copilot AI commented Mar 28, 2026

Copy link
Copy Markdown
Contributor

The existing '*.*.*' tag pattern matched any three-dot-separated strings (e.g. debug.some-random-ass-tag-with-dots.tmp), not just version tags.

Change

Updated the deploy workflow tag filter to require each of the first three segments to begin with a digit, while still allowing arbitrary pre-release suffixes. GitHub Actions tag filters use glob syntax (not regex), so * is used as the wildcard:

# before
- '*.*.*'

# after
- '[0-9]*.[0-9]*.[0-9]*'

Matches 0.1.2, 0.1.2-rc.3, 0.1.2-alpha.1, etc. Rejects non-version tags like debug.some-random-ass-tag-with-dots.tmp.


💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the deployment GitHub Actions workflow to trigger only on version-like tags, instead of any tag containing two dots.

Changes:

  • Replaced the on.push.tags filter pattern in the deploy workflow to better target SemVer-ish tags.

Comment thread .github/workflows/deploy.yaml Outdated
@KSXGitHub

Copy link
Copy Markdown
Owner

@copilot Do you think this review is valid?

If it's valid, implement it.

If it's not valid, tell me why.

@github-actions

Copy link
Copy Markdown

Performance Regression Reports

commit: e74fb6e

There are no regressions.

Copilot AI commented Mar 28, 2026

Copy link
Copy Markdown
Contributor Author

@copilot Do you think this review is valid?

If it's valid, implement it.
...

The review is valid — GitHub Actions tag filters use glob syntax, not regex, so + is a literal character. Fixed in 65b3985 by using [0-9]*.[0-9]*.[0-9]*, which correctly anchors each segment to start with a digit while using a proper glob wildcard for the rest.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@KSXGitHub KSXGitHub marked this pull request as ready for review March 28, 2026 19:45
@KSXGitHub KSXGitHub merged commit f032de5 into master Mar 28, 2026
4 checks passed
@KSXGitHub KSXGitHub deleted the copilot/update-deploy-yaml-version-matching branch March 28, 2026 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants