ci(deploy): tighten tag filter to digit-led version segments#381
Merged
Conversation
Agent-Logs-Url: https://github.com/KSXGitHub/parallel-disk-usage/sessions/4d866da6-60e6-4962-9658-a4977fcc24ee Co-authored-by: KSXGitHub <11488886+KSXGitHub@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
KSXGitHub
March 28, 2026 19:26
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the deployment GitHub Actions workflow to trigger only on version-like tags, instead of any tag containing two dots.
Changes:
- Replaced the
on.push.tagsfilter pattern in the deploy workflow to better target SemVer-ish tags.
Owner
|
@copilot Do you think this review is valid? If it's valid, implement it. If it's not valid, tell me why. |
Performance Regression Reportscommit: e74fb6e There are no regressions. |
…ex quantifiers Agent-Logs-Url: https://github.com/KSXGitHub/parallel-disk-usage/sessions/4880ae01-691e-46b0-a9b2-934028669017 Co-authored-by: KSXGitHub <11488886+KSXGitHub@users.noreply.github.com>
Contributor
Author
The review is valid — GitHub Actions tag filters use glob syntax, not regex, so |
KSXGitHub
approved these changes
Mar 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing
'*.*.*'tag pattern matched any three-dot-separated strings (e.g.debug.some-random-ass-tag-with-dots.tmp), not just version tags.Change
Updated the deploy workflow tag filter to require each of the first three segments to begin with a digit, while still allowing arbitrary pre-release suffixes. GitHub Actions tag filters use glob syntax (not regex), so
*is used as the wildcard:Matches
0.1.2,0.1.2-rc.3,0.1.2-alpha.1, etc. Rejects non-version tags likedebug.some-random-ass-tag-with-dots.tmp.💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.