ci: add dylint check using perfectionist#406
Merged
Merged
Conversation
Wire up the `perfectionist` dylint library so its lints run alongside the existing fmt and clippy checks. The library is referenced via git in `dylint.toml`, pinned to the commit that matches the published `0.0.0-rc.0` release on crates.io; `cargo-dylint` does not currently support registry sources. `test.sh` gains a `DYLINT` toggle (default `false`) that runs `cargo dylint --all -- --all-features --all-targets` once, outside the per-feature `unit` loop, since the lints inspect source style and a single `--all-features` pass already covers conditional code. CI runs this through a dedicated `dylint.yaml` workflow that installs `cargo-dylint` and `dylint-link`, matching the project's convention of one workflow per concern.
Performance Regression Reportscommit: 6538608 --quantity=apparent-size --max-depth=1 --min-ratio=0.01 --progress
LogsJSON{
"results": [
{
"command": "pdu",
"mean": 0.11276324715793101,
"stddev": 0.031216042834741036,
"median": 0.10235504702,
"user": 0.05316148482758621,
"system": 0.30359381931034474,
"min": 0.10223236202000001,
"max": 0.20344198202000002,
"times": [
0.10235331102,
0.10243091002,
0.10234009602000001,
0.10239104102,
0.10237954902,
0.10236045502,
0.10235634402,
0.10230845102000001,
0.10233988102000001,
0.10228686402,
0.10237289902,
0.20344198202000002,
0.10229802302,
0.10239662002000001,
0.10235310302,
0.10231348102,
0.10232951802000001,
0.10239427702000001,
0.10232529602000001,
0.10237196802000001,
0.10234492802,
0.10235914902,
0.10235659902000001,
0.10228207302,
0.20265445502,
0.20308914502,
0.10223236202000001,
0.10235504702,
0.10231634002000001
],
"exit_codes": [
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0
]
},
{
"command": "pdu-0.20.0",
"mean": 0.10229393284758621,
"stddev": 0.00003433261054748042,
"median": 0.10229850402,
"user": 0.05464369172413792,
"system": 0.2994437158620689,
"min": 0.10221929702,
"max": 0.10237007502,
"times": [
0.10229254002,
0.10236177102,
0.10233739202,
0.10230763002,
0.10229850402,
0.10225903302,
0.10224383602,
0.10227032002,
0.10224255302,
0.10230125102000001,
0.10230676002,
0.10230642902,
0.10230332602,
0.10230750202000001,
0.10229771502,
0.10226338002,
0.10230913902000001,
0.10237007502,
0.10231551702000001,
0.10230690902,
0.10229073202000001,
0.10230868702000001,
0.10228260402,
0.10221929702,
0.10226508202000001,
0.10228710102,
0.10234071102,
0.10227735502,
0.10225090102
],
"exit_codes": [
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0
]
}
]
} |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a Dylint-based CI check (using the perfectionist lint set) and wires it into the project’s local/CI guidance so contributors can run the same linting flow.
Changes:
- Add
DYLINTsupport totest.shto optionally runcargo dylint. - Introduce
dylint.tomlpinning theperfectionistdylint library by git revision. - Add a dedicated GitHub Actions workflow for dylint, and update contributor / AI instruction docs to include
DYLINT=trueusage and setup.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
test.sh |
Adds optional cargo dylint step gated by DYLINT. |
dylint.toml |
Declares the perfectionist dylint library (pinned rev). |
.github/workflows/dylint.yaml |
New CI job to run dylint via ./test.sh with DYLINT=true. |
CONTRIBUTING.md |
Documents installing dylint tooling and running DYLINT=true ./test.sh. |
template/ai-instructions/shared.md |
Updates shared AI quick-reference to include dylint tooling and DYLINT=true run. |
CLAUDE.md |
Mirrors shared AI instructions update for Claude. |
AGENTS.md |
Mirrors shared AI instructions update for agents. |
.github/copilot-instructions.md |
Mirrors shared AI instructions update for GitHub Copilot. |
KSXGitHub
commented
May 10, 2026
KSXGitHub
commented
May 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.