refactor: add if guard to par_cull_insignificant_data#426
Merged
Conversation
…cull_insignificant_data Move the early-out for non-positive ratios into the method so callers no longer need to wrap it in an `if min_ratio > 0.0` guard. The guard also covers NaN so the method is a no-op for every ratio that is not greater than zero, matching the behavior the call-site guards provided. https://claude.ai/code/session_01Nj3xEp1eoDKRp1MUCxNQRQ
Performance Regression Reportscommit: 164ac27 There are no regressions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.