refactor: extract chart-layout arguments of visualize_json_tree into a struct#429
Merged
Conversation
Performance Regression Reportscommit: e46ade4 There are no regressions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #427.
Group the chart-layout arguments of
visualize_json_treeinto a newChartLayoutstruct, mirroring the existingJsonInputShapingpattern.The struct holds the three values that stay constant across the method's branches:
column_width_distributiondirectionbar_alignmentbytes_formatis intentionally left out, since it is a generic associated type that differs per branch and concerns number formatting rather than chart geometry.This is a pure refactoring of a private method with no behavioral or CLI changes.