lint: upgrade perfectionist#437
Draft
KSXGitHub wants to merge 1 commit into
Draft
Conversation
KSXGitHub
force-pushed
the
claude/jolly-wright-imZGL
branch
from
8c01b7e to
34b22aa
Compare
Performance Regression Reportscommit: 40e4bce There are no regressions. |
Bump the dylint library tag from `0.0.0-rc.17` to `0.0.0-rc.18` and bring the tree into compliance with the rules it adds or extends: - `import_grouping` (new, active): configured for the `single_group` style. Blank lines that split an import run are removed so each module keeps one contiguous `use` block. - `bare_identifier_reference` (new, active): backticked identifiers in doc comments that resolve in scope are now written as intra-doc links. - `prefer_expect_over_allow` (new, active): the `clippy::float_cmp` suppressions in the fraction tests switch from `#[allow]` to `#[expect]`. - `prefer_raw_string` (broadened in KSXGitHub/perfectionist#233): the rule now scans macro arguments, so the roff `write!`/`format!` strings in `man_page` become raw strings. The rendered man page is byte-for-byte unchanged. The `single_group` style cannot keep `#[cfg]`-gated imports in their own trailing group, so files that rely on that layout carry a module-level `#[expect(perfectionist::import_grouping)]`. This limitation is tracked in #436. https://claude.ai/code/session_016ZyYFnzSv876usUHLEX4qe
KSXGitHub
force-pushed
the
claude/jolly-wright-imZGL
branch
from
34b22aa to
ae61ecf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades
perfectionistfrom0.0.0-rc.17to0.0.0-rc.18and brings the tree into compliance with the rules it adds or extends.New active rules
import_grouping— configured for thesingle_groupstyle. Blank-split import runs are collapsed so each module keeps one contiguoususeblock.bare_identifier_reference— backticked identifiers in doc comments that resolve in scope are rewritten as intra-doc links.prefer_expect_over_allow— theclippy::float_cmpsuppressions in the fraction tests move from#[allow]to#[expect].Extended rule
prefer_raw_stringnow scans macro arguments (upstream bug fix), so the roffwrite!/format!strings inman_pagebecome raw strings. The rendered man page is byte-for-byte unchanged.Known limitation
The
single_groupstyle cannot keep#[cfg]-gated imports in their own trailing group, so the affected files carry a module-level#[expect(perfectionist::import_grouping)]. Tracked in #436.No pre-existing
perfectionistworkarounds or lint suppressions existed to remove;inline_test_footprint(the rename ofunit_test_file_layout) and thederive_orderingcfg_attrfixes required no changes, as the tree already complied.