Skip to content

Commit 8416e41

Browse files
committed
Fixes
1 parent d74538d commit 8416e41

2 files changed

Lines changed: 20 additions & 11 deletions

File tree

DESCRIPTION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ Imports:
2222
hdf5r,
2323
kwb.event,
2424
kwb.utils,
25+
lubridate,
2526
magrittr,
2627
plotly,
2728
purrr,
@@ -32,7 +33,6 @@ Suggests:
3233
DT,
3334
future,
3435
future.apply,
35-
ggplot2,
3636
knitr,
3737
rmarkdown
3838
VignetteBuilder:

vignettes/workflow_eisenstadt-2005.Rmd

Lines changed: 19 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@ knitr::opts_chunk$set(
1212
collapse = TRUE,
1313
comment = "#>"
1414
)
15-
is_ghactions <- identical(Sys.getenv("CI"), "true")
16-
#is_ghactions <- FALSE
15+
#is_ghactions <- identical(Sys.getenv("CI"), "true")
16+
is_ghactions <- FALSE
1717
```
1818

1919
### Define Paths and Scenarios
@@ -292,11 +292,20 @@ params <- c(
292292
)
293293
294294
pdff <- "simulation_results_optimisation_main-effects.pdf"
295+
296+
gg <- kwb.raindrop::plot_main_effects(
297+
df = simulation_results_optimisation,
298+
y = "n_overflows",
299+
params = params
300+
)
301+
302+
# --- 1) Statisch ins PDF: kein Plotly dazwischen!
295303
kwb.utils::preparePdf(pdfFile = pdff)
296-
gg <- kwb.raindrop::plot_main_effects(df = simulation_results_optimisation,
297-
y = "n_overflows",
298-
params = params)
304+
print(gg)
305+
dev.off()
306+
#kwb.utils::finishAndShowPdf(pdff)
299307
308+
# --- 2) Interaktiv als HTML: nach dem PDF
300309
plotly_gg <- plotly::ggplotly(gg)
301310
302311
htmlwidgets::saveWidget(
@@ -305,8 +314,7 @@ htmlwidgets::saveWidget(
305314
selfcontained = TRUE,
306315
title = "RAINDROP - Main Effects"
307316
)
308-
gg
309-
kwb.utils::finishAndShowPdf(pdff)
317+
310318
311319
312320
pdff <- "simulation_results_optimisation_design-space_mulde-area_vs_parameters.pdf"
@@ -340,8 +348,8 @@ for (y in c("mulde_height", "filter_hydraulicconductivity", "storage_height")) {
340348
# statisch ins PDF (WICHTIG!)
341349
suppressWarnings(print(p))
342350
}
343-
344-
kwb.utils::finishAndShowPdf(pdff)
351+
dev.off()
352+
#kwb.utils::finishAndShowPdf(pdff)
345353
346354
pdff <- "simulation_results_optimisation_water-balance.pdf"
347355
kwb.utils::preparePdf(pdfFile = pdff)
@@ -364,6 +372,7 @@ p <- kwb.raindrop::plot_wb_tradeoff_overflows(
364372
365373
# statisch ins PDF (WICHTIG!)
366374
suppressWarnings(print(p))
367-
kwb.utils::finishAndShowPdf(pdff)
375+
dev.off()
376+
#kwb.utils::finishAndShowPdf(pdff)
368377
369378
```

0 commit comments

Comments
 (0)