Skip to content

Update logic to ensure values and options are independant #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stevehine wants to merge 1 commit into
base: mock-data-api-dynamic-lists
Choose a base branch
from
Open

Update logic to ensure values and options are independant #60

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions CoreRuntime/src/services/DataRetrievalService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,18 +55,21 @@ export class DataRetrievalService {
const responseData = await this.makeRequest(externalUrl, requestData);

// Structured response: apply scalar values and dynamic options separately
if (responseData.values && typeof responseData.values === 'object') {
Object.assign(data, responseData.values);

if (responseData.options && typeof responseData.options === 'object') {
if ((responseData.values && typeof responseData.values === 'object')
|| (responseData.options && typeof responseData.values === 'object')) {
if (responseData.values) {
Object.assign(data, responseData.values);
}
if (responseData.options) {
for (const element of allElements) {
const dynamicOptions = responseData.options[element.name];
if (dynamicOptions && 'options' in element) {
(element as unknown as FixedOptionValueElement).options = dynamicOptions;
}
}
}
} else {
}
else {
// Legacy flat response — merge directly into data for backward compatibility
Object.assign(data, responseData);
}
Expand Down