Skip to content

Commit 19c36ec

Browse files
KaliCZclaude
andauthored
Drop --no-build from pack step (#29)
The main csproj has an Analyzer ProjectReference to StrongTypes.SourceGenerators. With --no-build, pack still needs to resolve project references and invokes the Build target on the generator project, which then fails with NETSDK1085 because NoBuild is set. Letting pack perform a (no-op incremental) build sidesteps this. The Pack step only runs on main pushes, so PR CI never exercised it — both #25 and #26 merged green and broke main. A follow-up should make this fail fast in PR CI. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 2b98fb4 commit 19c36ec

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.github/workflows/build-and-test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ jobs:
5050

5151
- name: Pack
5252
if: github.ref == 'refs/heads/main' && github.event_name == 'push'
53-
run: dotnet pack ./src/StrongTypes/StrongTypes.csproj -c $config --no-build -o out
53+
run: dotnet pack ./src/StrongTypes/StrongTypes.csproj -c $config -o out
5454

5555
- name: Upload NuGet package
5656
if: github.ref == 'refs/heads/main' && github.event_name == 'push'

0 commit comments

Comments
 (0)