Fix non-todo sonar issues

Author: Kaliumhexacyanoferrat

API/Protocol/IResponseBuilder.cs

@@ -5,7 +5,7 @@ namespace GenHTTP.Api.Protocol;
 public interface IResponseBuilder : IBuilder<IResponse>
 {
 
-    IResponseBuilder Status(ResponseStatus code);
+    IResponseBuilder Status(ResponseStatus status);
 
     IResponseBuilder Connection(Connection mode);
 

Engine/Internal/Context/ClientContext.cs

@@ -31,11 +31,11 @@ internal sealed class ClientContext
 
     private PipeWriter? _writer;
 
-    private Request _request = new();
+    private readonly Request _request = new();
 
-    private ResponseHandler _responseHandler;
+    private readonly ResponseHandler _responseHandler;
 
-    private ClientHandler _clientHandler;
+    private readonly ClientHandler _clientHandler;
 
     internal IServer Server => _server ?? throw new InvalidOperationException("Handler has not been initialized");
 

Engine/Shared/Types/Body/ChunkedBodyStream.cs

@@ -15,7 +15,7 @@ internal sealed class ChunkedBodyStream : Stream, IDrainableStream
 {
     private readonly PipeReader _reader;
 
-    private GlyphParser _parser;
+    private readonly GlyphParser _parser = new();
 
     private bool _completed;
 
@@ -56,47 +56,47 @@ public ChunkedBodyStream(PipeReader reader)
     public override Task<int> ReadAsync(byte[] buffer, int offset, int count, CancellationToken cancellationToken)
         => ReadAsync(buffer.AsMemory(offset, count), cancellationToken).AsTask();
 
-    public override async ValueTask<int> ReadAsync(Memory<byte> destination, CancellationToken cancellationToken = default)
+    public override async ValueTask<int> ReadAsync(Memory<byte> buffer, CancellationToken cancellationToken = default)
     {
-        if (_completed || destination.IsEmpty)
+        if (_completed || buffer.IsEmpty)
         {
             return 0;
         }
 
         // Return buffered overflow from a previous large chunk first.
         if (_overflowLength > 0)
         {
-            return ConsumeOverflow(destination.Span);
+            return ConsumeOverflow(buffer.Span);
         }
 
         while (true)
         {
             var result = await _reader.ReadAsync(cancellationToken);
-            var buffer = result.Buffer;
+            var readBuffer = result.Buffer;
 
             byte[]? rented = null;
             ReadOnlySpan<byte> span;
 
-            if (buffer.IsSingleSegment)
+            if (readBuffer.IsSingleSegment)
             {
-                span = buffer.First.Span;
+                span = readBuffer.First.Span;
             }
             else
             {
                 // Linearise the full multi-segment buffer so Glyph11 gets a contiguous view.
                 // Glyph11 requires the complete chunk to be present before returning Chunk;
                 // capping would cause perpetual NeedMoreData for chunks larger than the cap.
-                var len = (int)buffer.Length;
+                var len = (int)readBuffer.Length;
                 rented = ArrayPool<byte>.Shared.Rent(len);
-                buffer.CopyTo(rented);
+                readBuffer.CopyTo(rented);
                 span = rented.AsSpan(0, len);
             }
 
             try
             {
                 if (span.IsEmpty)
                 {
-                    _reader.AdvanceTo(buffer.Start, buffer.End);
+                    _reader.AdvanceTo(readBuffer.Start, readBuffer.End);
 
                     if (result.IsCompleted)
                     {
@@ -111,12 +111,12 @@ public override async ValueTask<int> ReadAsync(Memory<byte> destination, Cancell
                 switch (chunkResult)
                 {
                     case ChunkResult.Completed:
-                        _reader.AdvanceTo(buffer.GetPosition(bytesConsumed));
+                        _reader.AdvanceTo(readBuffer.GetPosition(bytesConsumed));
                         _completed = true;
                         return 0;
 
                     case ChunkResult.NeedMoreData:
-                        _reader.AdvanceTo(buffer.Start, buffer.End);
+                        _reader.AdvanceTo(readBuffer.Start, readBuffer.End);
 
                         if (result.IsCompleted)
                         {
@@ -127,10 +127,10 @@ public override async ValueTask<int> ReadAsync(Memory<byte> destination, Cancell
 
                     case ChunkResult.Chunk:
                         var chunk = span.Slice(dataOffset, dataLength);
-                        var toCopy = Math.Min(destination.Length, dataLength);
+                        var toCopy = Math.Min(buffer.Length, dataLength);
 
                         // Copy to caller's buffer BEFORE advancing the pipe reader to keep span valid.
-                        chunk[..toCopy].CopyTo(destination.Span);
+                        chunk[..toCopy].CopyTo(buffer.Span);
 
                         if (toCopy < dataLength)
                         {
@@ -141,7 +141,7 @@ public override async ValueTask<int> ReadAsync(Memory<byte> destination, Cancell
                             _overflowLength = dataLength - toCopy;
                         }
 
-                        _reader.AdvanceTo(buffer.GetPosition(bytesConsumed));
+                        _reader.AdvanceTo(readBuffer.GetPosition(bytesConsumed));
                         return toCopy;
                 }
             }

Engine/Shared/Types/Body/LengthLimitedStream.cs

@@ -34,27 +34,27 @@ public LengthLimitedStream(PipeReader reader, long contentLength)
     public override Task<int> ReadAsync(byte[] buffer, int offset, int count, CancellationToken cancellationToken)
         => ReadAsync(buffer.AsMemory(offset, count), cancellationToken).AsTask();
 
-    public override async ValueTask<int> ReadAsync(Memory<byte> destination, CancellationToken cancellationToken = default)
+    public override async ValueTask<int> ReadAsync(Memory<byte> buffer, CancellationToken cancellationToken = default)
     {
         if (_bytesRemaining <= 0)
         {
             return 0;
         }
 
         var result = await _reader.ReadAsync(cancellationToken);
-        var buffer = result.Buffer;
+        var readBuffer = result.Buffer;
 
-        var toRead = (int)Math.Min(Math.Min(destination.Length, _bytesRemaining), buffer.Length);
+        var toRead = (int)Math.Min(Math.Min(buffer.Length, _bytesRemaining), readBuffer.Length);
 
         if (toRead == 0)
         {
-            _reader.AdvanceTo(buffer.Start, buffer.End);
+            _reader.AdvanceTo(readBuffer.Start, readBuffer.End);
             return 0;
         }
 
-        buffer.Slice(0, toRead).CopyTo(destination.Span);
+        readBuffer.Slice(0, toRead).CopyTo(buffer.Span);
 
-        _reader.AdvanceTo(buffer.GetPosition(toRead));
+        _reader.AdvanceTo(readBuffer.GetPosition(toRead));
 
         _bytesRemaining -= toRead;
         return toRead;

Engine/Shared/Types/Request.cs

@@ -83,7 +83,7 @@ public Request()
 
     #region Functionality
 
-    public IRequestBody? GetBody(HeaderAccess headerAccess)
+    public IRequestBody? GetBody(HeaderAccess headerAccess = HeaderAccess.Retain)
     {
         if (_bodyLoaded)
         {

Modules/Archives/Tree/ArchivedTree.cs

@@ -21,11 +21,11 @@ public sealed class ArchivedTree(ChangeTrackingResource source) : IResourceTree
 
     public DateTime? Modified => source.Modified;
 
-    public async ValueTask<IResourceNode?> TryGetNodeAsync(PathSegment name)
+    public async ValueTask<IResourceNode?> TryGetNodeAsync(PathSegment segment)
     {
         await EnsureRoot();
 
-        return await _root!.TryGetNodeAsync(name);
+        return await _root!.TryGetNodeAsync(segment);
     }
 
     public async ValueTask<IReadOnlyCollection<IResourceNode>> GetNodes()

Modules/Compression/DecompressedContent.cs

@@ -1,5 +1,3 @@
-namespace GenHTTP.Modules.Compression;
-
 /// <summary>
 /// Provides automatic decompression of incoming request content.
 /// </summary>

Modules/Compression/Providers/DecompressionConcern.cs

@@ -1,5 +1,3 @@
-namespace GenHTTP.Modules.Compression.Providers;
-
 /// <summary>
 /// Concern that automatically decompresses incoming request content
 /// based on the Content-Encoding header.

Modules/Compression/Providers/DecompressionConcernBuilder.cs

@@ -1,5 +1,3 @@
-namespace GenHTTP.Modules.Compression.Providers;
-
 /// <summary>
 /// Builder for configuring automatic request content decompression.
 /// </summary>

Modules/Compression/Providers/WrappedRequest.cs

@@ -1,5 +1,3 @@
-namespace GenHTTP.Modules.Compression.Providers;
-
 /// <summary>
 /// Wraps an existing request to provide decompressed content stream.
 /// </summary>