Further optimize response writing

- Add a specific overload for the newly used span based write methods
- Use specific stream type to avoid virtual calls

Author: Kaliumhexacyanoferrat

Engine/Internal/Infrastructure/Endpoints/EndPoint.cs

@@ -5,6 +5,7 @@
 using GenHTTP.Api.Infrastructure;
 
 using GenHTTP.Engine.Internal.Protocol;
+using GenHTTP.Engine.Internal.Utilities;
 using GenHTTP.Engine.Shared.Infrastructure;
 
 namespace GenHTTP.Engine.Internal.Infrastructure.Endpoints;
@@ -98,7 +99,7 @@ private void Handle(Socket client)
 
     protected abstract ValueTask Accept(Socket client);
 
-    protected ValueTask Handle(Socket client, Stream inputStream, X509Certificate? clientCertificate = null)
+    protected ValueTask Handle(Socket client, PoolBufferedStream inputStream, X509Certificate? clientCertificate = null)
     {
         client.NoDelay = true;
 

Engine/Internal/Protocol/ChunkedStream.cs

@@ -1,4 +1,6 @@
-namespace GenHTTP.Engine.Internal.Protocol;
+using GenHTTP.Engine.Internal.Utilities;
+
+namespace GenHTTP.Engine.Internal.Protocol;
 
 /// <summary>
 /// Implements chunked transfer encoding by letting the client
@@ -9,7 +11,7 @@
 /// soon as there is no known content length. To avoid this overhead,
 /// specify the length of your content whenever possible.
 /// </remarks>
-public sealed class ChunkedStream(Stream target) : Stream
+public sealed class ChunkedStream(PoolBufferedStream target) : Stream
 {
 
     #region Get-/Setters

Engine/Internal/Protocol/ClientHandler.cs

@@ -7,6 +7,7 @@
 using GenHTTP.Api.Protocol;
 
 using GenHTTP.Engine.Internal.Protocol.Parser;
+using GenHTTP.Engine.Internal.Utilities;
 using GenHTTP.Engine.Shared.Infrastructure;
 using GenHTTP.Engine.Shared.Types;
 
@@ -38,7 +39,7 @@ internal sealed class ClientHandler
 
     internal X509Certificate? ClientCertificate { get; set; }
 
-    internal Stream Stream { get; }
+    internal PoolBufferedStream Stream { get; }
 
     private bool? KeepAlive { get; set; }
 
@@ -48,7 +49,7 @@ internal sealed class ClientHandler
 
     #region Initialization
 
-    internal ClientHandler(Socket socket, Stream stream, X509Certificate? clientCertificate, IServer server, IEndPoint endPoint, NetworkConfiguration config)
+    internal ClientHandler(Socket socket, PoolBufferedStream stream, X509Certificate? clientCertificate, IServer server, IEndPoint endPoint, NetworkConfiguration config)
     {
         Server = server;
         EndPoint = endPoint;

Engine/Internal/Protocol/ResponseHandler.cs

@@ -3,6 +3,7 @@
 using GenHTTP.Api.Infrastructure;
 using GenHTTP.Api.Protocol;
 
+using GenHTTP.Engine.Internal.Utilities;
 using GenHTTP.Engine.Shared.Infrastructure;
 
 namespace GenHTTP.Engine.Internal.Protocol;
@@ -16,15 +17,15 @@ internal sealed class ResponseHandler
 
     private Socket Socket { get; }
 
-    private Stream Output { get; }
+    private PoolBufferedStream Output { get; }
 
     private NetworkConfiguration Configuration { get; }
 
     #endregion
 
     #region Initialization
 
-    internal ResponseHandler(IServer server, Socket socket, Stream output, NetworkConfiguration configuration)
+    internal ResponseHandler(IServer server, Socket socket, PoolBufferedStream output, NetworkConfiguration configuration)
     {
         Server = server;
         Socket = socket;

Engine/Internal/Protocol/StreamExtensions.cs

@@ -1,12 +1,14 @@
 using System.Runtime.CompilerServices;
 
+using GenHTTP.Engine.Internal.Utilities;
+
 namespace GenHTTP.Engine.Internal.Protocol;
 
 internal static class StreamExtensions
 {
 
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    internal static void Write(this Stream stream, string value)
+    internal static void Write(this PoolBufferedStream stream, string value)
     {
         Span<byte> buffer = stackalloc byte[value.Length];
 
@@ -19,7 +21,7 @@ internal static void Write(this Stream stream, string value)
     }
 
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    internal static void Write(this Stream stream, long number)
+    internal static void Write(this PoolBufferedStream stream, long number)
     {
         Span<byte> buffer = stackalloc byte[20];
 
@@ -34,7 +36,7 @@ internal static void Write(this Stream stream, long number)
     }
 
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    internal static void Write(this Stream stream, ulong number)
+    internal static void Write(this PoolBufferedStream stream, ulong number)
     {
         Span<byte> buffer = stackalloc byte[20];
 
@@ -49,7 +51,7 @@ internal static void Write(this Stream stream, ulong number)
     }
 
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    internal static void Write(this Stream stream, DateTime time)
+    internal static void Write(this PoolBufferedStream stream, DateTime time)
     {
         Span<char> charBuffer = stackalloc char[29]; // RFC1123 format is 29 chars
 

Engine/Internal/Utilities/PoolBufferedStream.cs

@@ -1,4 +1,5 @@
 using System.Buffers;
+using System.Runtime.CompilerServices;
 
 namespace GenHTTP.Engine.Internal.Utilities;
 
@@ -118,6 +119,33 @@ public override async Task WriteAsync(byte[] buffer, int offset, int count, Canc
         await WriteAsync(buffer.AsMemory(offset, count - offset), cancellationToken);
     }
 
+    [MethodImpl(MethodImplOptions.AggressiveInlining)]
+    public override void Write(ReadOnlySpan<byte> buffer)
+    {
+        var toWrite = buffer.Length;
+
+        if (toWrite <= Buffer.Length - Current)
+        {
+            buffer.CopyTo(Buffer.AsSpan(Current));
+            Current += toWrite;
+            return;
+        }
+
+        if (Current > 0)
+        {
+            WriteBuffer();
+        }
+
+        if (toWrite > Buffer.Length)
+        {
+            Stream.Write(buffer);
+            return;
+        }
+
+        buffer.CopyTo(Buffer);
+        Current = toWrite;
+    }
+
     public override async ValueTask WriteAsync(ReadOnlyMemory<byte> buffer, CancellationToken cancellationToken = default)
     {
         var count = buffer.Length;