Skip to content

Resolve Ruff TODOs #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Avasam wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Resolve Ruff TODOs #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions docs/source/conf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,10 @@
# -- Project information -----------------------------------------------------
# https://www.sphinx-doc.org/en/master/usage/configuration.html#project-information

import os
import re
import time
from urllib.request import urlretrieve

project = 'EWMHlib'
year = time.strftime("%Y")
Expand Down Expand Up @@ -42,9 +44,6 @@

# -- Copy the modules documentation ------------------------------------------
# https://stackoverflow.com/questions/66495200/is-it-possible-to-include-external-rst-files-in-my-documentation
from urllib.request import urlretrieve
import os

urlretrieve(
"https://raw.githubusercontent.com/kalmat/ewmhlib/master/README.md",
"index.md"
Expand Down
10 changes: 0 additions & 10 deletions ruff.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,16 +45,6 @@ ignore = [

# TODO: Add and configure isort (I) first
"RUF022",
Comment on lines 46 to 47

@Avasam Avasam Jul 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

About this TODO still left.

A thing with Ruff import sorting https://docs.astral.sh/ruff/settings/#lintisort
Is that Ruff doesn't support your current import style. (I believe the original isort would: https://isort.readthedocs.io/en/latest/configuration/multi_line_output_modes.html )

Image

If you like or don't mind that style, I can add it so you get consistent import sorting without any additional tooling.
If you don't like it and would rather keep your current style, I'll take note of it and update this comment. And I'll separately suggest the original isort tool.


# TODO: Consider later
"UP031", # printf-string-formatting
"RUF059", # unused-unpacked-variable

# TODO: Not autofixable, address in a separate PR !
"E722",
"E402",
"F401",
"ANN201",
]
# F401 would remove imports not marked as explicit re-exports, which may break API boundaries
extend-unsafe-fixes = ["F401"]
Expand Down