Skip to content

Add missing CI tests + Fix Watchdog racing condition#100

Merged
Kalmat merged 2 commits into
Kalmat:masterfrom
Avasam:type-check-on-all-supported-versions
Jun 17, 2026
Merged

Add missing CI tests + Fix Watchdog racing condition#100
Kalmat merged 2 commits into
Kalmat:masterfrom
Avasam:type-check-on-all-supported-versions

Conversation

@Avasam

@Avasam Avasam commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator
  • mypy is os and python-version sensitive. Test on all supported combinations
    • If you don't want to run a full matrix, we should at least do oldest + newest python versions supported as to cover the extreme ends of the range.
  • Added github action concurrency cancellation
  • Added missing runtime tests
  • Added missing and sphinx tests. (done in Migrate dependency management to PEP 735 + Add sphinx build CI check #98)
  • Fixed and simplified some flaky tests.
  • Fixed a potential racing condition in Watchdog

Edit: Already done in previous PR
I think you should enable Build pull requests for this project in https://app.readthedocs.org/dashboard/pywinctl/edit/
See: https://docs.readthedocs.com/platform/stable/pull-requests.html
(Sphinx test can fail sooner directly in CI, RTD PR validation can catch specifics to RTD)

@Avasam Avasam requested a review from Kalmat June 16, 2026 00:07
@Avasam Avasam force-pushed the type-check-on-all-supported-versions branch 2 times, most recently from 4f5a52e to b10b98b Compare June 16, 2026 00:28
@Avasam Avasam changed the title type-check on all supported versions Add missing CI tests Jun 16, 2026
@Avasam Avasam force-pushed the type-check-on-all-supported-versions branch 5 times, most recently from 72bc099 to 7d4a0a1 Compare June 16, 2026 04:14
@Avasam Avasam changed the title Add missing CI tests Add missing CI tests + Fix Watchdog racing condition Jun 16, 2026
@Avasam Avasam force-pushed the type-check-on-all-supported-versions branch 10 times, most recently from b478cd2 to 4d3a76a Compare June 16, 2026 20:18
@Avasam

Avasam commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator Author

I still got the following flakes. They should be addressed eventually, but in the mean time, if a test fail, any Collaborator can just press the "Re-run failed jobs" button.

macOS

https://github.com/Kalmat/PyWinCtl/actions/runs/27644692386/job/81753454477?pr=100#step:7:93

WINDOW PARENT: ('AXApplication', 'TextEdit') True
MENU INFO (WORKING IN WINDOWS 10 AND MACOS, BUT NOT IN WINDOWS 11 NOR LINUX)
    subfillit(nameList[1][i][0], sizeList[1][i][0], posList[1][i][0], attrList[1][i][0] if addItemInfo else [],
  File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/pywinctl/_pywinctl_macos.py", line 1543, in subfillit
    subfillit(submenu, subSize, subPos, subAttr,
  File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/pywinctl/_pywinctl_macos.py", line 1536, in subfillit
    subSize = subSize[j]
IndexError: list index out of range

Linux

Action deadlocked and timed out: https://github.com/Kalmat/PyWinCtl/actions/runs/27644692386/job/81753454508?pr=100#step:6:15
May require additional tracing to debug.

@Avasam Avasam force-pushed the type-check-on-all-supported-versions branch 3 times, most recently from 84023d5 to 8cc0860 Compare June 16, 2026 20:26
@Kalmat

Kalmat commented Jun 17, 2026

Copy link
Copy Markdown
Owner

Hi again!

I have re-run the tests. Everything went ok in my case.

image

Previous PR (#99) was ok, but I get some conflicts in this one too (I would resolve them by myself, but I don't have even a clue on what is this all about, my apologies).

Thanks!

@Avasam Avasam force-pushed the type-check-on-all-supported-versions branch 2 times, most recently from f58d0aa to d51455e Compare June 17, 2026 17:58
@Avasam Avasam force-pushed the type-check-on-all-supported-versions branch from 0aac7f6 to 3169dfd Compare June 17, 2026 18:06
@Kalmat Kalmat merged commit 7a29aca into Kalmat:master Jun 17, 2026
39 checks passed
@Avasam Avasam deleted the type-check-on-all-supported-versions branch June 18, 2026 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants