Add missing CI tests + Fix Watchdog racing condition#100
Merged
Kalmat merged 2 commits intoJun 17, 2026
Conversation
4f5a52e to
b10b98b
Compare
72bc099 to
7d4a0a1
Compare
b478cd2 to
4d3a76a
Compare
Collaborator
Author
|
I still got the following flakes. They should be addressed eventually, but in the mean time, if a test fail, any Collaborator can just press the "Re-run failed jobs" button. macOShttps://github.com/Kalmat/PyWinCtl/actions/runs/27644692386/job/81753454477?pr=100#step:7:93 LinuxAction deadlocked and timed out: https://github.com/Kalmat/PyWinCtl/actions/runs/27644692386/job/81753454508?pr=100#step:6:15 |
84023d5 to
8cc0860
Compare
Owner
|
Hi again! I have re-run the tests. Everything went ok in my case.
Previous PR (#99) was ok, but I get some conflicts in this one too (I would resolve them by myself, but I don't have even a clue on what is this all about, my apologies). Thanks! |
f58d0aa to
d51455e
Compare
0aac7f6 to
3169dfd
Compare
Kalmat
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Added missing and sphinx tests.(done in Migrate dependency management to PEP 735 + Add sphinx build CI check #98)Edit: Already done in previous PR
I think you should enableBuild pull requests for this projectin https://app.readthedocs.org/dashboard/pywinctl/edit/See: https://docs.readthedocs.com/platform/stable/pull-requests.html(Sphinx test can fail sooner directly in CI, RTD PR validation can catch specifics to RTD)