Full PEP 517 + PEP 639#101
Merged
Merged
Conversation
Avasam
force-pushed
the
PEP-517-+-PEP-639
branch
10 times, most recently
from
0af11de to
793c817
Compare
Owner
|
Sorry, some other conflicts arose (I don't know if you already receive the warnings regarding conflicts... so just in case). |
Avasam
force-pushed
the
PEP-517-+-PEP-639
branch
2 times, most recently
from
3760dda to
04b70f1
Compare
Avasam
force-pushed
the
PEP-517-+-PEP-639
branch
from
04b70f1 to
9737eb3
Compare
Avasam
commented
Jun 18, 2026
Comment on lines
+2
to
+6
| requires = ["setuptools>=77.0.3", "setuptools-scm"] | ||
| build-backend = "setuptools.build_meta" | ||
|
|
||
| [tool.setuptools.dynamic] | ||
| version = { attr = "pywinctl.__version__" } # any module attribute compatible with ast.literal_eval |
Collaborator
Author
There was a problem hiding this comment.
Take a look at #105
If you decide that you prefer flit-core or uv-build, I could change it here now.
Kalmat
approved these changes
Jun 18, 2026
Owner
|
Sorry I didn't see your last comment before merging. If your recommendation is uv-build, let's go for it (please, check my answer to #105). Are we still on time to make the change here? Please, let me know what I have to do next in order to avoid interfering with your work, Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like you were mostly there, just had some cruft to remove.
This caught that the license SPDX identifier was invalid.
Added more
project.urls(and moved the section closer to project metadata in the config file)Added missing
Programming Language :: PythonversionsRemoved redundant
packages.find.where(setuptools autodiscovers standard src-layouts as of v61)Removed redundant
py.typedpackage_data(setuptools autodiscovers it as of v69)Removed License classifier as those are deprecated by
PEP 639. (setuptools will warn about it as of v77)