Enforce modern best practices concerning annotations, typing and symbol import/export#102
Merged
Merged
Conversation
4eb3179 to
63d933e
Compare
Avasam
commented
Jun 16, 2026
1aab2ff to
ce5221b
Compare
ce5221b to
3cf4bf8
Compare
Owner
|
Sorry. Should I merge this PR or just wait? |
Collaborator
Author
|
#101 has been merged. You can merge this now. I tried to keep my PRs as isolated as possible for review and history. Of course I expected some overlap and conflicts. |
Kalmat
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overlaps with #101, probably merge that one first to reduce changes.
Mostly taken from my own shared config file: https://github.com/Beslogic/Beslogic-Ruff-Config/blob/main/ruff.toml
But scoped to only rule groups that concern modernization and best practices for annotations, typing and symbol import/export.
Most of this was autofixed.
The most immediate effects here are:
Anyif return type annotation is missing, where every other type checker will infer from the function body)