Avoid bare except#103
Open
Avasam wants to merge 1 commit into
Open
Conversation
Owner
|
Same question for this one... should I merge it now? |
Collaborator
Author
|
Yeah you can merge it now. |
Owner
|
It raises a conflict (a very stupid one, IMO) EDIT: I could resolve it myself (this one is very simple), but I am not sure what are the implications in your own code (you would not have that change, right?) |
Collaborator
Author
|
I would after pulling back the branch. Which I have to do everytime when starting a new branch from master anyway. |
Replaced bare `except:` clauses with `except Exception:`, preventing accidental suppression of system-exit signals (`KeyboardInterrupt`, `SystemExit`) during error handling. Which is almost never intended.
Avasam
force-pushed
the
Avoid-bare-except
branch
from
f28a8a3 to
e7e70ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced bare
except:clauses withexcept Exception:, preventing accidental suppression of system-exit signals (KeyboardInterrupt,SystemExit) during error handling. Which is almost never intended.