Plugins::Telnet: modify security level

Author: KangLin

Plugins/Telnet/OperateTelnet.cpp

@@ -14,7 +14,6 @@ COperateTelnet::COperateTelnet(CPlugin *parent)
     : COperateTerminal(parent)
     , m_Telnet(QTelnet::TCP)
     , m_bLogin(false)
-    , m_SecurityLevel(CSecurityLevel::Level::Risky)
 {
     qDebug(log) << Q_FUNC_INFO;
     auto &net = m_Parameters.m_Net;
@@ -30,11 +29,6 @@ COperateTelnet::~COperateTelnet()
     qDebug(log) << Q_FUNC_INFO;
 }
 
-CSecurityLevel::Level COperateTelnet::GetSecurityLevel() const
-{
-    return m_SecurityLevel;
-}
-
 QDialog *COperateTelnet::OnOpenDialogSettings(QWidget *parent)
 {
     return new CDlgSettingsTelnet(&m_Parameters, parent);
@@ -52,6 +46,8 @@ int COperateTelnet::Start()
 
     slotUpdateParameter(this);
 
+    slotSetSecurityLevel(CSecurityLevel::Level::Risky);
+
     bool check = false;
     check = connect(&m_Telnet, &QTelnet::stateChanged,
                     this, [=](QAbstractSocket::SocketState socketState){
@@ -157,7 +153,7 @@ const QString COperateTelnet::Name()
         auto &net = m_Parameters.m_Net;
         if(!net.GetHost().isEmpty()) {
             if(m_Parameters.GetGlobalParameters()
-                && (GetParameter()->GetGlobalParameters()->GetNameStyles()
+                && (m_Parameters.GetGlobalParameters()->GetNameStyles()
                      & CParameterPlugin::NameStyle::Protocol)
                 && !Protocol().isEmpty())
                 szName = Protocol() + ":";
@@ -170,7 +166,8 @@ const QString COperateTelnet::Name()
 
     QString szSecurityLevel;
     CSecurityLevel sl(GetSecurityLevel());
-    if((GetParameter()->GetGlobalParameters()->GetNameStyles()
+    if(m_Parameters.GetGlobalParameters()
+        && (m_Parameters.GetGlobalParameters()->GetNameStyles()
          & CParameterPlugin::NameStyle::SecurityLevel)
         && GetSecurityLevel() != CSecurityLevel::Level::No
         && !sl.GetUnicodeIcon().isEmpty())
@@ -246,8 +243,7 @@ void COperateTelnet::slotNewData(const char *buf, int len)
                 m_Telnet.sendData(password.toStdString().c_str(), password.length());
                 m_Telnet.sendData("\n", 1);
                 m_bLogin = true;
-                m_SecurityLevel = CSecurityLevel::Level::Authentication;
-                slotSetSecurityLevel(m_SecurityLevel);
+                slotSetSecurityLevel(CSecurityLevel::Level::Authentication);
             }
             qDebug(log) << "Password:" << password;
 

Plugins/Telnet/OperateTelnet.h

@@ -15,7 +15,6 @@ class COperateTelnet : public COperateTerminal
 
 public:
     [[nodiscard]] virtual CBackend *InstanceBackend() override;
-    [[nodiscard]] virtual CSecurityLevel::Level GetSecurityLevel() const override;
     virtual int Start() override;
     virtual int Stop() override;
 
@@ -30,9 +29,7 @@ private Q_SLOTS:
     CParameterTelnet m_Parameters;
     QTelnet m_Telnet;
     bool m_bLogin;
-    CSecurityLevel::Level m_SecurityLevel;
-    
-    // COperate interface
+
 public:
     virtual const QString Id() override;
     virtual const QString Name() override;

Src/Operate.h

@@ -382,8 +382,13 @@ class PLUGIN_EXPORT COperate : public QObject
 
     //!@{
     //! \~chinese \name 统计
-    //! \~english \name Stats
+    //! \~english \name Statistics
 public:
+    /*!
+     * \~chinese 得到统计信息。如果有，其派生类则需要重载此函数提供统计信息。
+     * \~english Get statistics. If so, its derived class needs to overload this function to provide statistical information.
+     * \return Statistics pointer
+     */
     [[nodiscard]] virtual CStats* GetStats();
     /*!
      * \brief Get Security Level

Src/Terminal/OperateTerminal.cpp

@@ -89,6 +89,30 @@ COperateTerminal::~COperateTerminal()
     }
 }
 
+const QString COperateTerminal::Id()
+{
+    QString szId = COperate::Id();
+    if(GetParameter()) {
+        if(GetParameter()->GetName().isEmpty())
+            szId += "_" + Name();
+        else
+            szId += "_" + GetParameter()->GetName();
+    }
+    static QRegularExpression exp("[-@:/#%!^&* \\.]");
+    szId = szId.replace(exp, "_");
+    return szId;
+}
+
+const QString COperateTerminal::Name()
+{
+    QString szName;
+    if(GetParameter())
+        szName = GetParameter()->GetName();
+    if(szName.isEmpty())
+        szName = COperate::Name();
+    return szName;
+}
+
 const QString COperateTerminal::Description()
 {
     QString szDescription;
@@ -121,6 +145,21 @@ const QString COperateTerminal::Description()
     return szDescription;
 }
 
+const qint16 COperateTerminal::Version() const
+{
+    return 0;
+}
+
+const QString COperateTerminal::Details()
+{
+    QString szDetails;
+    szDetails = "  - " + tr("QTermWidget") + "\n" +
+                "    - " + tr("Version:") + " " + QString("%1.%2.%3").arg(QTERMWIDGET_VERSION_MAJOR)
+                                                      .arg(QTERMWIDGET_VERSION_MINOR)
+                                                      .arg(QTERMWIDGET_VERSION_PATCH) + "\n";
+    return szDetails;
+}
+
 QWidget* COperateTerminal::GetViewer()
 {
     return m_pTerminal;
@@ -337,21 +376,6 @@ void COperateTerminal::slotFocusOut()
     SetShotcuts(false);
 }
 
-const qint16 COperateTerminal::Version() const
-{
-    return 0;
-}
-
-const QString COperateTerminal::Details()
-{
-    QString szDetails;
-    szDetails = "  - " + tr("QTermWidget") + "\n" +
-                "    - " + tr("Version:") + " " + QString("%1.%2.%3").arg(QTERMWIDGET_VERSION_MAJOR)
-                      .arg(QTERMWIDGET_VERSION_MINOR)
-                      .arg(QTERMWIDGET_VERSION_PATCH) + "\n";
-    return szDetails;
-}
-
 int COperateTerminal::SetGlobalParameters(CParameterPlugin *pPara)
 {
     Q_ASSERT(pPara);
@@ -424,26 +448,3 @@ void COperateTerminal::SetShotcuts(bool bEnable)
     m_pClear->setShortcut(QKeySequence());
 }
 
-const QString COperateTerminal::Id()
-{
-    QString szId = COperate::Id();
-    if(GetParameter()) {
-        if(GetParameter()->GetName().isEmpty())
-            szId += "_" + Name();
-        else
-            szId += "_" + GetParameter()->GetName();
-    }
-    static QRegularExpression exp("[-@:/#%!^&* \\.]");
-    szId = szId.replace(exp, "_");
-    return szId;
-}
-
-const QString COperateTerminal::Name()
-{
-    QString szName;
-    if(GetParameter())
-        szName = GetParameter()->GetName();
-    if(szName.isEmpty())
-        szName = COperate::Name();
-    return szName;
-}