App: add drag and drop in favorite

KangLin · KangLin · commit a1e7ff2cd173 · 2026-03-09T07:35:31.000+08:00
diff --git a/App/Client/Favorite/FavoriteModel.cpp b/App/Client/Favorite/FavoriteModel.cpp
@@ -270,6 +270,47 @@ bool CFavoriteModel::UpdateFavorite(
     return true;
 }
 
+bool CFavoriteModel::Move(QModelIndex index, QModelIndex parentIndex)
+{
+    if(!index.isValid()) return false;
+    tree* ip = GetTree(index);
+    if(!ip) return false;
+    tree* ipParent = GetTree(parentIndex);
+    if(!ipParent || ipParent->item.isFavorite()) return false;
+    int nParentId = ipParent->item.id;
+    auto& item = ip->item;
+    bool bRet = false;
+    if(item.isFavorite())
+        bRet = m_pDatabase->Move(item.id, nParentId);
+    else
+        bRet = m_pDatabase->MoveNode(item.id, nParentId);
+    if(!bRet) return false;
+    bRet = MoveTree(ip->item, ipParent->item.id);
+    return bRet;
+}
+
+// TODO: not test!!!
+bool CFavoriteModel::Copy(QModelIndex index, QModelIndex parentIndex)
+{
+    bool bRet = true;
+    if(!index.isValid()) return false;
+    tree* ip = GetTree(index);
+    if(!ip) return false;
+    tree* ipParent = GetTree(parentIndex);
+    if(!ipParent || ipParent->item.isFavorite()) return false;
+    int nParentId = ipParent->item.id;
+    auto& item = ip->item;
+    if(item.isFavorite())
+        bRet = AddFavorite(item.szFile, item.szName, item.GetIcon(),
+                           item.szDescription, nParentId);
+    else {
+        bRet = m_pDatabase->AddNode(item.szName, nParentId);
+        if(!bRet) return false;
+        bRet = AddTree(item, nParentId);
+    }
+    return bRet;
+}
+
 CFavoriteDatabase::Item CFavoriteModel::GetFavorite(const QString &szFile)
 {
     CFavoriteDatabase::Item item;
diff --git a/App/Client/Favorite/FavoriteModel.h b/App/Client/Favorite/FavoriteModel.h
@@ -26,6 +26,8 @@ class CFavoriteModel : public QAbstractItemModel
     CFavoriteDatabase::Item GetFavorite(const QString& szFile);
     void Refresh();
 
+    bool Move(QModelIndex index, QModelIndex parentIndex);
+    bool Copy(QModelIndex index, QModelIndex parentIndex);
     enum RoleType {
         RoleFile = Qt::UserRole,
         RoleNodeType,
diff --git a/App/Client/Favorite/FavoriteView.cpp b/App/Client/Favorite/FavoriteView.cpp
@@ -185,7 +185,14 @@ void CFavoriteView::setupTreeView(QLayout *layout)
         return;
     layout->addWidget(m_pTreeView);
 
+    //m_pTreeView->installEventFilter(this);
+    m_pTreeView->viewport()->installEventFilter(this);
     m_pTreeView->setAcceptDrops(true);
+    m_pTreeView->setDragEnabled(true);
+    m_pTreeView->setDragDropMode(QTreeView::InternalMove);
+    m_pTreeView->setDefaultDropAction(Qt::MoveAction);
+    m_pTreeView->setDropIndicatorShown(true);
+
     m_pTreeView->setUniformRowHeights(true);
     m_pTreeView->setHeaderHidden(true);
 
@@ -508,77 +515,110 @@ void CFavoriteView::slotExport()
 
 void CFavoriteView::dragEnterEvent(QDragEnterEvent *event)
 {
-    qDebug(log) << "dragEnterEvent";
+    qDebug(log) << Q_FUNC_INFO;
     const CFavoriteMimeData* pData =
         qobject_cast<const CFavoriteMimeData*>(event->mimeData());
     if (pData)
     {
         qDebug(log) << "dragEnterEvent acceptProposedAction";
         event->acceptProposedAction();
-    }
+        /*
+        // 设置拖拽时的光标
+        if (event->proposedAction() == Qt::MoveAction) {
+            setCursor(Qt::DragMoveCursor);
+        } else {
+            setCursor(Qt::DragCopyCursor);
+        }//*/
+    } else
+        event->ignore();
 }
 
 void CFavoriteView::dragMoveEvent(QDragMoveEvent *event)
 {
+    qDebug(log) << Q_FUNC_INFO;
+    const CFavoriteMimeData* pData =
+        qobject_cast<const CFavoriteMimeData*>(event->mimeData());
+    if (!pData)
+    {
+        event->ignore();
+        return;
+    }
+
+    // 获取鼠标位置下的索引
+    QModelIndex index = m_pTreeView->indexAt(event->pos());
+
+    // 检查是否可以放置
+    if (index.isValid()) {
+        // 这里可以添加验证逻辑，比如不能将文件夹拖到自身
+        event->acceptProposedAction();
+
+        // 更新拖拽指示器位置
+        m_pTreeView->updateDropIndicator(event->pos());
+
+        // 自动展开文件夹（如果悬停足够长时间）
+        if (!isExpanded(index) && m_DragHoverIndex != index) {
+            m_DragHoverIndex = index;
+            QTimer::singleShot(500, [this, index]() {
+                if (m_Dragging && m_DragHoverIndex == index) {
+                    expand(index);
+                }
+            });
+        }
+    } else {
+        // 允许拖拽到空白区域（根节点）
+        event->acceptProposedAction();
+    }
+
+    m_pTreeView->viewport()->update(); // 触发重绘以显示指示器
 }
 
 void CFavoriteView::dropEvent(QDropEvent *event)
 {
-    qDebug(log) << "dropEvent";
+    qDebug(log) << Q_FUNC_INFO << "drop action:" << event->dropAction();
+
     const CFavoriteMimeData *pData = qobject_cast<const CFavoriteMimeData*>(event->mimeData());
-    if(!pData) return;
-    /*
-    QStandardItemModel* pModel = dynamic_cast<QStandardItemModel*>(model());
-    if(!pModel) return;
+    if(!pData || pData->m_Items.isEmpty() || !m_pTreeView || !m_pModel) {
+        event->ignore();
+        return;
+    }
+
+    bool bRet = false;
 #if QT_VERSION >= QT_VERSION_CHECK(6, 0, 0)
-    auto index = indexAt(event->position().toPoint());
+    auto idxParent = m_pTreeView->indexAt(event->position().toPoint());
 #else
-    auto index = indexAt(event->pos());
+    auto idxParent = m_pTreeView->indexAt(event->pos());
 #endif
-    if(index.isValid())
+
+    CFavoriteDatabase::Item item
+        = m_pModel->data(idxParent, CFavoriteModel::RoleItem)
+              .value<CFavoriteDatabase::Item>();
+    if(0 < item.id && item.isFolder())
     {
-        auto item = pModel->itemFromIndex(index);
-        if(item->data().isNull())
-        {
-            foreach(auto i, pData->m_Items)
-            {
-                qDebug(log) << "dropEvent:" << item->text();
-                
-                auto newItem = NewItem(i);
-                item->appendRow(newItem);
-                if(event->dropAction() == Qt::MoveAction)
-                    pModel->removeRow(i.row(), i.parent());
-            } 
-        } else
-            qWarning(log) << "Don't group node. the data:" << item->data();
-    }else{
         foreach(auto i, pData->m_Items)
         {
-            pModel->appendRow(NewItem(i));
-            if(event->dropAction() == Qt::MoveAction)
-                pModel->removeRow(i.row(), i.parent());
+            if (event->dropAction() == Qt::MoveAction)
+                bRet = m_pModel->Move(i, idxParent);
+            else if (event->dropAction() == Qt::CopyAction)
+                bRet = m_pModel->Copy(i, idxParent);
+            if(!bRet) break;
         }
+    } else {
+        qWarning(log) << "Don't group node. the id:" << item.id
+                      << " Folder:" << item.isFolder();
     }
-//*/
-    event->accept();
-}
-/*
-QStandardItem* CFavoriteView::NewItem(const QModelIndex &index)
-{
-    QStandardItemModel* pModel = dynamic_cast<QStandardItemModel*>(model());
-    if(!pModel) return nullptr;
-    auto item = pModel->itemFromIndex(index);
-    if(!item) return nullptr;
-    auto ri = new QStandardItem(item->text());
-    ri->setData(item->data());
-    return ri;
+
+    if(bRet)
+        event->accept();
+    else
+        event->ignore();
 }
 
 void CFavoriteView::mousePressEvent(QMouseEvent *event)
 {
+    qDebug(log) << "mousePressEvent";
     if (event->button() == Qt::LeftButton)
         m_DragStartPosition = event->pos();
-    QTreeView::mousePressEvent(event);
+    QWidget::mousePressEvent(event);
 }
 
 void CFavoriteView::mouseMoveEvent(QMouseEvent *event)
@@ -591,22 +631,61 @@ void CFavoriteView::mouseMoveEvent(QMouseEvent *event)
                 < QApplication::startDragDistance())
             break;
         qDebug(log) << "mouseMoveEvent drag";
+        // 获取选中的索引
+        QModelIndexList indexes = m_pTreeView->selectionModel()->selectedIndexes();
+        if (indexes.isEmpty()) {
+            break;
+        }
         QDrag *drag = new QDrag(this);
         CFavoriteMimeData *pData = new CFavoriteMimeData();
-        pData->m_Items = this->selectionModel()->selectedIndexes();
+        pData->m_Items = indexes;
         drag->setMimeData(pData);
-        
         Qt::DropAction dropAction = Qt::MoveAction;
-        if(event->modifiers() & Qt::ControlModifier)
+        /*
+        if(event->modifiers() & Qt::ControlModifier) {
             dropAction = Qt::CopyAction;
+            // 设置拖拽时的光标
+            // QIcon icon = QIcon::fromTheme("edit-copy");
+            // QSize size(16, 16);
+            // if(!icon.availableSizes().isEmpty())
+            //     size = icon.availableSizes().at(0);
+            // drag->setDragCursor(icon.pixmap(size), Qt::MoveAction);
+        }//*/
         drag->exec(dropAction);
     } while (false);
     
-    QTreeView::mouseMoveEvent(event);
+    QWidget::mouseMoveEvent(event);
 }
-//*/
+
 bool CFavoriteView::eventFilter(QObject *watched, QEvent *event)
 {
+    // 处理 treeview 的事件
+    if (watched == m_pTreeView->viewport()) { // 处理 viewport 的事件
+        qDebug(log) << Q_FUNC_INFO << "Viewport event:" << event->type();
+
+        switch (event->type()) {
+        case QEvent::DragEnter:
+            dragEnterEvent(static_cast<QDragEnterEvent*>(event));
+            return true;
+        case QEvent::DragMove:
+            dragMoveEvent(static_cast<QDragMoveEvent*>(event));
+            return true;
+        case QEvent::Drop:
+            dropEvent(static_cast<QDropEvent*>(event));
+            return true;
+        case QEvent::MouseButtonPress:
+            mousePressEvent(static_cast<QMouseEvent*>(event));
+            // 不返回true，让 viewport 也处理
+            break;
+        case QEvent::MouseMove:
+            mouseMoveEvent(static_cast<QMouseEvent*>(event));
+            // 不返回true，让 viewport 也处理
+            break;
+        default:
+            break;
+        }
+    }
+
     return QWidget::eventFilter(watched, event);
 }
 
diff --git a/App/Client/Favorite/FavoriteView.h b/App/Client/Favorite/FavoriteView.h
@@ -35,21 +35,20 @@ public Q_SLOTS:
                             const QString& szName = QString(),
                             const QString& szDescription = QString(),
                             const QIcon& icon = QIcon());
-    virtual bool eventFilter(QObject *watched, QEvent *event) override;
 
 Q_SIGNALS:
     void sigStart(const QString &szFile, bool bOpenSettings);
     void sigFavorite();
 
-    // QWidget interface
 protected:
+    virtual bool eventFilter(QObject *watched, QEvent *event) override;
     virtual void dragEnterEvent(QDragEnterEvent *event) override;
     virtual void dragMoveEvent(QDragMoveEvent *event) override;
     virtual void dropEvent(QDropEvent *event) override;
-/*
+
     virtual void mousePressEvent(QMouseEvent *event) override;
     virtual void mouseMoveEvent(QMouseEvent *event) override;
-  */
+
 private slots:
     void slotFavrtieClicked(const QModelIndex &index);
     void slotFavortiedoubleClicked(const QModelIndex &index);
