Skip to content

Commit e119b54

Browse files
committed
ci(code-quality): fix all jobs — remove cache, unify install flags
Root cause: without composer.lock, hashFiles('**/composer.lock') returns an empty string, so all jobs shared the same cache key 'Linux-composer-'. The security job installed with --no-dev and cached first; subsequent jobs restored that cache and ended up with a vendor/ missing dev packages. Fix: - Remove all Composer cache blocks (no lock file = no stable cache key; cold install on ubuntu-latest takes ~15s, not worth the risk) - Remove --no-dev from security job (composer audit works on installed packages — no need for a separate --no-dev install) - Add --no-scripts to all composer install steps - php bin/kcode in all kcode steps (vendor/bin/kcode is not created when running inside the devkit repo itself)
1 parent 0ce6e27 commit e119b54

1 file changed

Lines changed: 4 additions & 48 deletions

File tree

.github/workflows/code-quality.yml

Lines changed: 4 additions & 48 deletions
Original file line numberDiff line numberDiff line change
@@ -32,17 +32,6 @@ jobs:
3232
- name: Validate composer.json
3333
run: composer validate --strict --no-check-lock
3434

35-
- name: Get Composer cache directory
36-
id: composer-cache
37-
run: echo "dir=$(composer config cache-files-dir)" >> "$GITHUB_OUTPUT"
38-
39-
- name: Cache dependencies
40-
uses: actions/cache@v4
41-
with:
42-
path: ${{ steps.composer-cache.outputs.dir }}
43-
key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.json') }}
44-
restore-keys: ${{ runner.os }}-composer-
45-
4635
- name: Install dependencies
4736
run: composer install --prefer-dist --no-progress --no-scripts
4837

@@ -65,19 +54,8 @@ jobs:
6554
tools: composer:v2
6655
coverage: none
6756

68-
- name: Get Composer cache directory
69-
id: composer-cache
70-
run: echo "dir=$(composer config cache-files-dir)" >> "$GITHUB_OUTPUT"
71-
72-
- name: Cache dependencies
73-
uses: actions/cache@v4
74-
with:
75-
path: ${{ steps.composer-cache.outputs.dir }}
76-
key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }}
77-
restore-keys: ${{ runner.os }}-composer-
78-
79-
- name: Install dependencies (no-dev for audit)
80-
run: composer install --no-dev --prefer-dist --no-progress
57+
- name: Install dependencies
58+
run: composer install --prefer-dist --no-progress --no-scripts
8159

8260
- name: Run composer audit
8361
run: composer audit --format=plain
@@ -98,19 +76,8 @@ jobs:
9876
coverage: none
9977
tools: composer:v2
10078

101-
- name: Get Composer cache directory
102-
id: composer-cache
103-
run: echo "dir=$(composer config cache-files-dir)" >> "$GITHUB_OUTPUT"
104-
105-
- name: Cache dependencies
106-
uses: actions/cache@v4
107-
with:
108-
path: ${{ steps.composer-cache.outputs.dir }}
109-
key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }}
110-
restore-keys: ${{ runner.os }}-composer-
111-
11279
- name: Install dependencies
113-
run: composer install --prefer-dist --no-progress
80+
run: composer install --prefer-dist --no-progress --no-scripts
11481

11582
- name: Initialize devkit config
11683
run: php bin/kcode init
@@ -134,19 +101,8 @@ jobs:
134101
coverage: none
135102
tools: composer:v2
136103

137-
- name: Get Composer cache directory
138-
id: composer-cache
139-
run: echo "dir=$(composer config cache-files-dir)" >> "$GITHUB_OUTPUT"
140-
141-
- name: Cache dependencies
142-
uses: actions/cache@v4
143-
with:
144-
path: ${{ steps.composer-cache.outputs.dir }}
145-
key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }}
146-
restore-keys: ${{ runner.os }}-composer-
147-
148104
- name: Install dependencies
149-
run: composer install --prefer-dist --no-progress
105+
run: composer install --prefer-dist --no-progress --no-scripts
150106

151107
- name: Initialize devkit config
152108
run: php bin/kcode init

0 commit comments

Comments
 (0)