ci: use php bin/kcode instead of vendor/bin/kcode#6
Closed
walmir-silva wants to merge 2 commits intomainfrom
Closed
ci: use php bin/kcode instead of vendor/bin/kcode#6walmir-silva wants to merge 2 commits intomainfrom
walmir-silva wants to merge 2 commits intomainfrom
Conversation
Composer bin-linking only creates vendor/bin/ symlinks for packages installed as *dependencies* of a project. Within the devkit repository itself, kariricode/devkit is not its own dependency, so vendor/bin/kcode is never created. Fix: use 'php bin/kcode' directly in all workflow steps. Applies to: ci.yml (quality job) and code-quality.yml (phpstan, cs-fixer jobs).
Root cause: without composer.lock, hashFiles('**/composer.lock') returns
an empty string, so all jobs shared the same cache key 'Linux-composer-'.
The security job installed with --no-dev and cached first; subsequent jobs
restored that cache and ended up with a vendor/ missing dev packages.
Fix:
- Remove all Composer cache blocks (no lock file = no stable cache key;
cold install on ubuntu-latest takes ~15s, not worth the risk)
- Remove --no-dev from security job (composer audit works on installed
packages — no need for a separate --no-dev install)
- Add --no-scripts to all composer install steps
- php bin/kcode in all kcode steps (vendor/bin/kcode is not created when
running inside the devkit repo itself)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Composer bin-linking only creates vendor/bin/ symlinks for packages installed as dependencies of a project. Within the devkit repository itself, kariricode/devkit is not its own dependency, so vendor/bin/kcode is never created.
Fix: use 'php bin/kcode' directly in all workflow steps.
Applies to: ci.yml (quality job) and code-quality.yml (phpstan, cs-fixer jobs).