fix(ci): remove sed workarounds — devkit now generates correct phpunit config

The root fix is in kariricode-devkit (PhpUnitConfigGenerator.php):
- failOnWarning="false"  (was true)
- failOnRisky="false"    (was true)
- <source> without restrict* attributes (removed restrictDeprecations/
  restrictNotices/restrictWarnings)

All 'Patch phpunit.xml.dist' steps with sed commands are no longer needed.
Also reverts devkit.php coverage_exclude — DiscoveryException coverage
should remain tracked (the warning is now suppressed properly by the devkit).

Author: walmir-silva

.github/workflows/ci.yml

@@ -43,19 +43,6 @@ jobs:
       - name: Initialize devkit (.kcode/ generation)
         run: kcode init
 
-      # Patch generated phpunit.xml.dist — the devkit regenerates this file on every
-      # `kcode init` run, so patches must be applied here after initialization.
-      # Suppresses PHPUnit 12 false-positive warnings/notices/risky flags that do not
-      # reflect actual defects in this library (ARFA 1.3 compliance preserved).
-      - name: Patch phpunit.xml.dist
-        run: |
-          sed -i 's/failOnWarning="true"/failOnWarning="false"/' .kcode/phpunit.xml.dist
-          sed -i 's/failOnRisky="true"/failOnRisky="false"/' .kcode/phpunit.xml.dist
-          sed -i 's/beStrictAboutCoverageMetadata="true"/beStrictAboutCoverageMetadata="false"/' .kcode/phpunit.xml.dist
-          sed -i 's/ restrictWarnings="true"//g' .kcode/phpunit.xml.dist
-          sed -i 's/ restrictDeprecations="true"//g' .kcode/phpunit.xml.dist
-          sed -i 's/ restrictNotices="true"//g' .kcode/phpunit.xml.dist
-
       # cs-fixer → phpstan (L9) → psalm → phpunit
       # Exit code ≠ 0 fails the job (zero-tolerance policy)
       - name: Run full quality pipeline

.github/workflows/code-quality.yml

@@ -94,17 +94,6 @@ jobs:
       - name: Initialize devkit
         run: kcode init
 
-      # Patch generated phpunit.xml.dist — disable failOnWarning and strict
-      # coverage metadata to avoid false-positive warnings from PHPUnit 12.
-      - name: Patch phpunit.xml.dist
-        run: |
-          sed -i 's/failOnWarning="true"/failOnWarning="false"/' .kcode/phpunit.xml.dist
-          sed -i 's/failOnRisky="true"/failOnRisky="false"/' .kcode/phpunit.xml.dist
-          sed -i 's/beStrictAboutCoverageMetadata="true"/beStrictAboutCoverageMetadata="false"/' .kcode/phpunit.xml.dist
-          sed -i 's/ restrictWarnings="true"//g' .kcode/phpunit.xml.dist
-          sed -i 's/ restrictDeprecations="true"//g' .kcode/phpunit.xml.dist
-          sed -i 's/ restrictNotices="true"//g' .kcode/phpunit.xml.dist
-
       # Runs PHPStan Level 9 then Psalm sequentially — both must pass
       - name: Run PHPStan + Psalm via kcode
         run: kcode analyse
@@ -171,17 +160,6 @@ jobs:
       - name: Initialize devkit
         run: kcode init
 
-      # Patch generated phpunit.xml.dist — disable failOnWarning and strict
-      # coverage metadata to avoid false-positive warnings from PHPUnit 12.
-      - name: Patch phpunit.xml.dist
-        run: |
-          sed -i 's/failOnWarning="true"/failOnWarning="false"/' .kcode/phpunit.xml.dist
-          sed -i 's/failOnRisky="true"/failOnRisky="false"/' .kcode/phpunit.xml.dist
-          sed -i 's/beStrictAboutCoverageMetadata="true"/beStrictAboutCoverageMetadata="false"/' .kcode/phpunit.xml.dist
-          sed -i 's/ restrictWarnings="true"//g' .kcode/phpunit.xml.dist
-          sed -i 's/ restrictDeprecations="true"//g' .kcode/phpunit.xml.dist
-          sed -i 's/ restrictNotices="true"//g' .kcode/phpunit.xml.dist
-
       - name: Run tests with coverage (pcov)
         run: kcode test --coverage
 

devkit.php

@@ -43,7 +43,7 @@
     // ],
 
     // ── Coverage ──────────────────────────────────────────────
-    'coverage_exclude' => ['src/Exception'],
+    // 'coverage_exclude' => ['src/Exception'],
 
     // ── Code Style (MERGED with KaririCode defaults) ──────────
     // 'cs_fixer_rules' => [