prod #121 (comment)

Author: lzy7071

datanator_rest_api/routes/taxon.py

@@ -23,6 +23,8 @@ class canon_rank_distance_by_name:
 
     def get(name):
         results = t_manager.get_canon_rank_distance_by_name(name, front_end=True)
+        if results == [{name: 0}]:
+            return {"code": 404, "message": "Taxon not found."}, 404
         return results
 
 

datanator_rest_api/spec/DatanatorAPI.yaml

@@ -1865,6 +1865,12 @@ paths:
               schema:
                 $ref: '#/components/schemas/TxnCanonRankDistance'
           description: OK
+        '404':
+          content:
+            application/json:
+              schema:
+                $ref: '#/components/schemas/GeneralError'
+          description: Not found
       summary: |-
         Given the species name, return canonically-ranked ancestors
          along the lineage and their non-canonical distances.

datanator_rest_api/spec/paths/taxon.yaml

@@ -39,6 +39,12 @@ canon_rank_distance_by_name:
           application/json:
             schema:
               $ref: "#/components/schemas/TxnCanonRankDistance"
+      "404":
+        description: Not found
+        content:
+          application/json:
+            schema:
+              $ref: "#/components/schemas/GeneralError"
 
 is_child:
   get:

tests/routes/test_taxon.py

@@ -22,6 +22,8 @@ def test_canon_rank_distance(self):
     def test_canon_rank_distance_by_name(self):
         result = self.client.get('/taxon/canon_rank_distance_by_name/?name=homo sapiens')
         self.assertEqual(result.status_code, 200)
+        result = self.client.get('/taxon/canon_rank_distance_by_name/?name=xxxxx')
+        self.assertEqual(result.status_code, 404)
 
     def test_is_child(self):
         result = self.client.get('/taxon/is_child/?src_tax_ids=550690&target_tax_id=523')