Skip to content

Removed PVS studio from knp: #164 #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DavidIkov merged 2 commits into from
Mar 11, 2026
Merged

Removed PVS studio from knp: #164 #165

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
912072b
Removed PVS studio from knp: #164
DavidIkov Mar 6, 2026
e4eb3c8
Added back run_pvs script for internal CI: #164
DavidIkov Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions .github/workflows/cmake-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,13 @@ on:
- '!/docker/**'
- '!/tools/**'
- '!/ci/**'
pull_request_target:
types: [opened, synchronize, reopened]
pull_request:
branches: [ "master" ]

jobs:
linux_build:
runs-on: ${{ matrix.os }}
environment: pr-review-required

strategy:
# Set fail-fast to false to ensure that feedback is delivered for all matrix combinations. Consider changing this to true when your workflow is stable.
fail-fast: false
Expand Down Expand Up @@ -86,10 +86,6 @@ jobs:
run: docker run --platform=linux/${{ matrix.arch }} --rm -v ${{ github.workspace }}:/KNP -w /KNP kasperskydh/knp-build-image cmake --build ${{ steps.strings.outputs.build-output-dir }} --parallel ${{ matrix.build_threads_count }}
timeout-minutes: 180

# - name: Analyze C++ code with PVS Studio
# if: matrix.arch == 'amd64'
# run: docker run --platform=linux/${{ matrix.arch }} --rm -v ${{ github.workspace }}:/KNP -w /KNP kasperskydh/knp-build-image bash -c 'pvs-studio-analyzer credentials ${{ secrets.PVS_STUDIO_CREDENTIALS }} && cmake --build ${{ steps.strings.outputs.build-output-dir }} --parallel ${{ matrix.build_threads_count }} --target pvs-analyze'

- name: C++ tests
run: docker run --platform=linux/${{ matrix.arch }} --rm -v ${{ github.workspace }}:/KNP -w /KNP/${{ steps.strings.outputs.build-output-dir }}/knp/tests kasperskydh/knp-build-image ctest -V
timeout-minutes: 180
Expand Down
Loading