#KL26-90 IMU直進クラスの作成#19
Merged
Merged
Conversation
HaruArima08
requested changes
May 20, 2026
HaruArima08
left a comment
HaruArima08
left a comment
Collaborator
There was a problem hiding this comment.
見ました。
動作確認もできてるし特に問題ないと思います。
細かい修正とコメント書いてます。
よろしくお願いします。
nishijima515
approved these changes
May 20, 2026
nishijima515
left a comment
nishijima515
left a comment
Collaborator
There was a problem hiding this comment.
特に指摘するところはなかったので、先にapprove出しときます。LGTM！
takuchi17
requested changes
May 20, 2026
takuchi17
left a comment
takuchi17
left a comment
Contributor
There was a problem hiding this comment.
ほぼ問題ないと思います。
角度の正規化についてだけ、imuタスクと相談して同じ関数を使うようにしたい。imuタスクのコメント参考。
Collaborator
|
calculatorsに角度の正規化の作成は結局どっちでやることになってる？ |
HaruArima08
approved these changes
May 23, 2026
HaruArima08
left a comment
HaruArima08
left a comment
Collaborator
There was a problem hiding this comment.
対応ありがとうございます！
お疲れ様！
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
チェックリスト
変更点
動作テスト
https://www.notion.so/uom-katlab/IMU-360dd5b1cc18800fb69ce3d372036bf6?source=copy_link
実験方法
実験結果
添付資料
角度正規化クラス追加しました。レビューお願いします！