Skip to content

Commit 9de068f

Browse files
committed
fixed minor graphical issues and command runs on Windows
1 parent f22d6a0 commit 9de068f

4 files changed

Lines changed: 24 additions & 15 deletions

File tree

css/style.css

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,10 @@ body {
99
visibility: hidden;
1010
opacity: 0;
1111
}
12+
.anchor-id {
13+
position: absolute;
14+
margin-top: -130px;
15+
}
1216
/* scrollbar */
1317
::-webkit-scrollbar {
1418
width: 12px;

electronClient.js

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -51,13 +51,13 @@ ipcMain.on('script:copy', function(e, script){
5151
console.log("The script file was saved to " + path.join(tmp_folder, "script.sh"));
5252
console.log("Running " + path.join(tmp_folder, "script.sh"));
5353
if(isWin) {
54-
exec('' + path.join(tmp_folder, "script.sh"), function (err, stdout, stderr){
54+
exec('"' + path.join(tmp_folder, 'script.sh"'), function (err, stdout, stderr){
5555
//console.log(err, stdout, stderr);
5656
return;
5757
});
5858
}
5959
else {
60-
exec('bash \"' + path.join(tmp_folder, "script.sh\""), function (err, stdout, stderr) {
60+
exec('bash "' + path.join(tmp_folder, 'script.sh"'), function (err, stdout, stderr) {
6161
//console.log(err, stdout, stderr);
6262
return;
6363
});
@@ -68,7 +68,8 @@ ipcMain.on('script:copy', function(e, script){
6868
ipcMain.on('script:execute', function(e){
6969
console.log("Running LStart on " + path.join(tmp_folder, "lab"));
7070
if(isWin) {
71-
exec('start cmd /c "%NETKIT_HOME%\\lstart -d ' + path.join(tmp_folder, "lab") + '"', function (err, stdout, stderr) {
71+
console.log('start cmd /c \'%NETKIT_HOME%\\lstart -d "\\\"' + path.join(tmp_folder, "lab") + '\\\""\'');
72+
exec('start cmd /c \"%NETKIT_HOME%\\lstart -d "\\\"' + path.join(tmp_folder, "lab") + '\\\""\"', function (err, stdout, stderr) {
7273
//console.log(err, stdout, stderr);
7374
return;
7475
});
@@ -84,7 +85,7 @@ ipcMain.on('script:execute', function(e){
8485
ipcMain.on('script:clean', function(e){
8586
console.log("Running LClean on " + path.join(tmp_folder, "lab"));
8687
if(isWin) {
87-
exec('start cmd /c "%NETKIT_HOME%\\lclean -d ' + path.join(tmp_folder, "lab") + '"', function (err, stdout, stderr) {
88+
exec('start cmd /c \"%NETKIT_HOME%\\lclean -d "\\\"' + path.join(tmp_folder, "lab") + '\\\""\"', function (err, stdout, stderr) {
8889
//console.log(err, stdout, stderr);
8990
return;
9091
});

index.html

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,7 @@ <h4><a href="https://github.com/Kidel/Netkit-Lab-Generator" target="_blank">http
6868
<table id="labInfo">
6969
<tr>
7070
<th>Lab informations</th>
71+
<div id="labInfo_anchor" class="anchor-id"></div>
7172
</tr>
7273
<tr>
7374
<td>
@@ -107,8 +108,9 @@ <h4><a href="https://github.com/Kidel/Netkit-Lab-Generator" target="_blank">http
107108
<th colspan="4">Additional functions</th>
108109
</tr>
109110

110-
<tr data-ng-repeat="x in netkit track by $index" id="{{x._uid}}">
111+
<tr data-ng-repeat="x in netkit track by $index">
111112
<td>
113+
<div id="{{x._uid}}" class="anchor-id"></div>
112114
<div><label>Machine {{x.row}}:</label>
113115
<input type="text" data-ng-model="x.name" class="form-control" placeholder="pc" required /></div>
114116
<input title="type" type="radio" value="terminale" data-ng-model="x.type" /> Terminal<br />
@@ -302,29 +304,31 @@ <h4>Bash file preview:</h4>
302304
<div id="minimap-body" ng-style="{ 'transform': 'scale(1, ' + minimap_transform + ')' }">
303305
<span id="mock-main-menu" class="mock mock-main-menu"></span>
304306
<span class="mock mock-disclaimer" id="mock-disclaimer"></span>
305-
<div class="btn btn-default mock mock-labinfo" data-ng-click="scrollTo($event, 'labInfo')"></div>
307+
<div class="btn btn-default mock mock-labinfo" data-ng-click="scrollTo($event, 'labInfo_anchor')"></div>
306308
<div data-ng-repeat="x in netkit track by $index" class="btn btn-default mock mock-machine" ng:class="{true:'mock-machine-first', false:''}[$index==0]" data-ng-click="scrollTo($event, x._uid)"><span>{{$index+1}}</span>{{x.name}}</div>
307309
<div class="mock mock-preview-text">Bash file preview:</div>
308310
<span class="mock mock-preview"></span>
309311
</div>
310312
</div>
311313

312314
<!-- Sub-menu Run on Host -->
313-
<nav id="submenu-0" class="navbar navbar-primary navbar-kathara navbar-kathara-secondary ng-hide">
315+
<nav id="submenu-0" class="navbar navbar-primary navbar-kathara navbar-kathara-secondary ng-hide" style="height: 105px">
314316
<div class="container-fluid">
315317
<!-- Collect the nav links, forms, and other content for toggling -->
316318
<ul class="nav navbar-nav">
317319
<li><a id="copyLab"><i class="fas fa-copy"></i> <strong>Copy lab on Host *</strong></a></li>
318320
<li><a id="lstart"><i class="fas fa-play-circle"></i> <strong>Run LStart on Host **</strong></a></li>
319321
<li><a id="lclean"><i class="fas fa-stop-circle"></i> <strong>Run LClean on Host **</strong></a></li>
320322
</ul>
321-
<small>
322-
<div align="right" class="margin-top">
323-
* Requires something to run .sh files (like Git bash), even on Windows.
324-
<br />
323+
<div style="clear:both">
324+
<span class="label label-warning">
325+
* Requires something to run .sh files, even on Windows (like Git bash, associated with .sh files).
326+
</span>
327+
<br />
328+
<span class="label label-warning">
325329
** Requires Kathar&aacute; (or eventually Netkit) installed on Host and env configured correctly.
326-
</div>
327-
</small>
330+
</span>
331+
</div>
328332
</div><!-- /.container-fluid -->
329333
</nav>
330334

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
"scripts": {
77
"start": "electron .",
88
"package-mac": "electron-packager . --overwrite --platform=darwin --arch=x64 --icon=assets/icons/mac/icon.icns --prune=true --out=release-builds",
9-
"package-win": "electron-packager . --overwrite --asar=true --platform=win32 --arch=ia32 --icon=assets/icons/win/icon.ico --prune=true --out=release-builds --version-string.CompanyName=CE --version-string.FileDescription=CE --version-string.ProductName=\"KatharaGUI\"",
9+
"package-win": "electron-packager . --overwrite --asar --platform=win32 --arch=ia32 --icon=assets/icons/win/icon.ico --prune=true --out=release-builds --version-string.CompanyName=CE --version-string.FileDescription=CE --version-string.ProductName=\"KatharaGUI\"",
1010
"package-linux": "electron-packager . --overwrite --platform=linux --arch=x64 --icon=assets/icons/png/icon.png --prune=true --out=release-builds"
1111
},
1212
"author": "Gaetano Bonofiglio",
@@ -15,7 +15,7 @@
1515
"dom-minimap": "^1.7.2"
1616
},
1717
"devDependencies": {
18-
"electron": "^1.7.10",
18+
"electron": "^1.7.11",
1919
"electron-packager": "^10.1.1"
2020
}
2121
}

0 commit comments

Comments
 (0)